Opened 11 years ago

Closed 11 years ago

#4471 closed defect (fixed)

Can't close saved pdf in re-opened browse session

Reported by: carrott Owned by: manuq
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Browse Version: Unspecified
Severity: Unspecified Keywords: olpc-test-pending
Cc: Distribution/OS: OLPC
Bug Status: Unconfirmed

Description (last modified by carrott)

13.2.0 Build 1, XO-4, Browse 149.1

Open Browse
Navigate to a PDF such as ​http://www.beehive.govt.nz/sites/all/files/Novopay_Technical_Review.pdf
Click save to journal
Close Browse
Reopen Browse
Observe that PDF tab cannot be closed and the below error in the log

Traceback (most recent call last):
  File "/home/olpc/Activities/Browse.activity/browser.py", line 307, in __tab_close_cb
    tab_page.cancel_download()
  File "/home/olpc/Activities/Browse.activity/pdfviewer.py", line 415, in cancel_download
    self._download.cancel()
AttributeError: 'PDFTabPage' object has no attribute '_download'

This doesn't happen if you do not save the pdf to the journal or you close the pdf tab before closing browse.

Change History (2)

comment:1 Changed 11 years ago by carrott

  • Description modified (diff)

comment:2 Changed 11 years ago by manuq

  • Keywords olpc-test-pending added
  • Resolution set to fixed
  • Status changed from new to closed

Thank you very much for the report. Pushed fix as fad672c7 - will be in Browse 151.

Note: See TracTickets for help on using tickets.