Changes between Initial Version and Version 1 of Ticket #4414


Ignore:
Timestamp:
02/06/2013 19:44:01 (11 years ago)
Author:
manuq
Comment:

The consequence of set_transient_for() failing with a TypeError is that the Object Chooser of an activity is displayed over other activities and also over the Journal.

It fails because the Gtk.Window is passed from toolkit to the shell through DBUS as an integer, the XID of the X11Window (GdkWindow). It is sent in toolkit's ObjectChooser and catched in shell's JournalActivityDBusService . So at the other side we have a GdkWindow.

So I've found that calling the method with the same name in the Gdk.Window fixes the issue. There is no error in the log, and the Object Chooser acts as a dialog, attached to the activity Window. ​http://developer.gnome.org/gdk/stable/gdk-Windows.html#gdk-window-set-transient-for

Patch attached.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #4414

    • Property Summary changed from TypeError opening the object-chooser to Object Chooser of an activity gets over other activities

  • Ticket #4414 – Description

    initial v1  
    22- open imageviewer from scratch
    33- click the + button in the center of the canvas
    4 - check the logs
     4- Switch to other activities
    55
    6 Traceback:
     6The Object Chooser should be tied to the activity that opens it, as a dialog window.
     7
     8This traceback appears in the log:
    79{{{
    810Traceback (most recent call last):