Opened 10 years ago

Closed 7 years ago

Last modified 7 years ago

#440 closed defect (fixed)

Disable Esc (exit full screen mode) accelerator in Terminal.

Reported by: wadeb Owned by: wadeb
Priority: Normal Milestone: Unspecified
Component: Terminal Version: Git as of bugdate
Severity: Minor Keywords:
Cc: humitos Distribution/OS: Unspecified
Bug Status: New

Description

It's often handy to use Terminal in full screen mode.

Some terminal programs, like VIM, require use of the Esc key, but the Esc key exits full screen mode.

Terminal should disable the Esc accelerator, like it does with other accelerators.

Change History (9)

comment:1 Changed 9 years ago by wadeb

  • Milestone changed from 0.84 to Unspecified by Release Team
  • Owner changed from sayamindu to wadeb
  • Status changed from new to accepted

Not related to a milestone, just an enhancement. There is code in there to do it, but it's not working correctly.

comment:2 Changed 7 years ago by humitos

I was taking a look at this problem. I found something strange here.

I put a log.debug(self) and log.debug(self.__key_press_cb) in sugar.graphics.window.Window.__init__ to know if self was TerminalActivity and that is True.

Besides I put a log.debug('TerminalActivity.__key_press_cb') inside the TerminalActivity.__key_press_cb method to know if it's called.

11:48 < humitos> 1332254619.978885 DEBUG Window: <TerminalActivity object at 0x8c84a2c (SugarActivity at 0x8bdd170)>
11:48 < humitos> 1332254619.979220 DEBUG Window: <bound method TerminalActivity.__key_press_cb of <TerminalActivity object at 0x8c84a2c (SugarActivity at 0x8bdd170)>>

So, I don't understand why TerminalActivity.__key_press_cb is never called. In fact, it's never connected by the Window class.

I commented the connection line in Window class and put that line (the connection one) inside the TerminalActivity class and it works properly.

comment:4 Changed 7 years ago by humitos

I found and fix this problem. I'm talking with "manuq" to know how to create a patch for this.

comment:5 Changed 7 years ago by humitos

I've already sent the patch to the sugar-devel list:

comment:6 Changed 7 years ago by RafaelOrtiz

Applied..thus closing this one.

comment:7 Changed 7 years ago by RafaelOrtiz

  • Resolution set to fixed
  • Status changed from accepted to closed

comment:9 Changed 7 years ago by humitos

  • Cc humitos added
Note: See TracTickets for help on using tickets.