Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#4328 closed defect (fixed)

Journal traceback, fails to start in right to left languages

Reported by: garycmartin Owned by:
Priority: Urgent Milestone:
Component: journal Version: 0.98.x
Severity: Blocker Keywords: 13.1.0, regression, r+, olpc-test-passed
Cc: dsd, manuq, erikos Distribution/OS: OLPC
Bug Status: Unconfirmed

Description

Testing 13.1.0 Build 18

Journal fails to start when a right to left language is active, e.g. Arabic (Egypt). See attached shell.log for full traceback.

  File "/usr/lib/python2.7/site-packages/jarabe/journal/detailview.py", line 102, in __init__
    hbox.reverse()
AttributeError: 'HBox' object has no attribute 'reverse'

Attachments (2)

shell.log​ (1.7 KB) - added by garycmartin 11 years ago.
0001-Journal-fix-layout-reordering-for-right-to-left-lang.patch​ (2.0 KB) - added by manuq 11 years ago.
Proposed patch.

Download all attachments as: .zip

Change History (10)

Changed 11 years ago by garycmartin

comment:1 Changed 11 years ago by garycmartin

  • Cc manuq erikos added

comment:2 Changed 11 years ago by dsd

  • Keywords regression added

Changed 11 years ago by manuq

Proposed patch.

comment:3 Changed 11 years ago by manuq

  • Keywords r? added

comment:4 Changed 11 years ago by manuq

I have grepped the code and found no more instances of this hippo reverse() in sugar:

src/jarabe/journal/model.py:285:                             reverse=(self._sort[0] == '-'))
src/jarabe/model/shell.py:616:            windows.reverse()

First is a parameter for the python list sort() method, second is Wnck .

comment:5 Changed 11 years ago by erikos

  • Keywords r+ added; r? removed

Works and code looks good, please push.

Thanks for checking occasions in the rest of the code base.

comment:6 Changed 11 years ago by manuq

  • Keywords olpc-test-pending added
  • Resolution set to fixed
  • Status changed from new to closed

Pushed 52076ffd .

comment:7 Changed 11 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

The journal is still accessible if the language is set to Arabic in Sugar 0.98.2/OLPC 13.1.0 os20.

comment:8 Changed 11 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.