Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4323 closed defect (fixed)

Spurious palette popup when clipboard clipping is created

Reported by: dsd Owned by: erikos
Priority: High Milestone:
Component: Sugar Version: 0.98.x
Severity: Unspecified Keywords: regression, olpc-test-passed
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

Tested on 13.1.0 build 18 on XO-4:

  1. Open Browse
  2. Select a word with the mouse
  3. Right click on the selection
  4. "Copy text"
  5. A pulsing clipping icon appears in the bottom left as expected, but the palette of the clipping also pops up in the bottom left, which is unexpected.

Attachments (4)

0001-clipboard-palette-port.patch (3.6 KB) - added by manuq 8 years ago.
I have tried a port to the palettes with custom widgets, but is not useful at all as we haven't implemented submenus in them.
shell-clipboard.log (101.4 KB) - added by manuq 8 years ago.
shell.log
0003-ClipboardIcon-set-active-property-via-the-parent-con.patch (1.5 KB) - added by manuq 8 years ago.
Shell patch.
0001-RadioToolButton-add-active-parameter-to-set-the-acti.patch (1.7 KB) - added by manuq 8 years ago.
Toolkit patch.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 8 years ago by dsd

  • Priority changed from Unspecified by Maintainer to High

Changed 8 years ago by manuq

I have tried a port to the palettes with custom widgets, but is not useful at all as we haven't implemented submenus in them.

Changed 8 years ago by manuq

shell.log

comment:2 Changed 8 years ago by manuq

Maybe this part of the log is useful:

1355766009.236325 DEBUG root: Clipboard.add_object: hash 1339541391
/usr/lib/python2.7/site-packages/gobject/constants.py:24: Warning: g_boxed_type_register_static: assertion `g_type_from_name (name) == 0' failed
  import gobject._gobject
1355766009.376989 DEBUG root: _update_open_submenu: ''
1355766009.442382 WARNING root: Trying to position palette with invoker that's not realized.
1355766009.445050 WARNING root: Trying to position palette with invoker that's not realized.
1355766009.446977 WARNING root: Trying to position palette with invoker that's not realized.
1355766009.446977 WARNING root: Trying to position palette with invoker that's not realized.
1355766009.448778 WARNING root: Trying to position palette with invoker that's not realized.

comment:3 follow-up: Changed 8 years ago by manuq

The above patch was pushed as 1dd2aec6 .

comment:4 in reply to: ↑ 3 Changed 8 years ago by manuq

Replying to manuq:

The above patch was pushed as 1dd2aec6 .

I mean, the patch for the static binding issue that can be see in the log above, which was attached to #4307

Changed 8 years ago by manuq

Toolkit patch.

comment:5 Changed 8 years ago by manuq

As erikos commented in #4307 here the 'clicked' signal is emited when the active property of the button is set, so the palette pops up. The attached two patches fix this.

comment:6 Changed 8 years ago by manuq

  • Keywords olpc-test-pending added
  • Resolution set to fixed
  • Status changed from new to closed

Fixed by Simon at #4307, pushed as 3859ff00 .

comment:7 Changed 8 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

In general the clipboard seems much better behaved, and I do not see this issue in OLPC 13.1.0 os21/Sugar 0.98.3.

comment:8 Changed 8 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.