Journal detail view: style favourite button correctly

[erikos]

At the moment the button does have a grey outline in active mode. It should look like the favourite button in the list view.

[humitos]

Screenshot comparing both

[humitos]

Attached 3 patches. This can't be done just with .css because the dark gray background will be kept in ":active" state after we click on the icon and leave it with the mouse pointer.

• sugar.patch:
  • Uses "button-press" and "button-release" to change the background properly
  • Changes the star colors on "enter-notify" and "leave-notify"
  • Sets the size of the widget
• sugar-artwork: Adds SugarKeepIcon to the ".cell.sugar-icon-cell" properties so they share the behaviour.
• sugar-toolkit-gtk3:
  • Adds a helper method called "get_gdk_rgba_color" to get a Gdk.RGBA color needed by "Widget.override_background_color"
  • Adds the background color needed by SugarKeepIcon

[manuq]

Shell patch based on humitos one.

[manuq]

Artwork patch.

[manuq]

Attached a follow up of humitos patches:

• use a custom CSS for the press state, so it can be styled in the theme, and there is no need for the toolkit patch

• in the CSS, reuse the CanvasIcon rules

• fix this issue on humitos patch:

with a non-starred entry,

1. do a mouse enter - star gets user colors
2. do a mouse leave - star gets white fill, but border is still on the user colors, should be grey

[erikos]

Ok, patch looks good, please remove the debug log. I tested with the mouse, please test with touch as well.

It can be classified a regression, since the mouse usage of this button does not work anymore as before.

[manuq]

Pushed shell dc027d62 and artwork 2b41125e .

[dnarvaez]

Milestone 0.98 deleted