Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4268 closed defect (fixed)

Radiotoolbutton: When changing the palettes using touch the tooltip stays

Reported by: erikos Owned by: erikos
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: Unspecified
Severity: Unspecified Keywords: r+, olpc-test-passed
Cc: walter, godiard Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

os15

  • open TA
  • change the Palettes (pen colour, ...) with touch

--> the tooltip stays visible

Attachments (2)

hide_tooltip_on_click.patch (1.2 KB) - added by erikos 8 years ago.
patch for toolkit-gtk3 (same API as for the ToolButton)
hide_tooltip_on_click_toolkit_gtk2.patch (500 bytes) - added by erikos 8 years ago.
toolkit-gtk2 patch (test with TA)

Download all attachments as: .zip

Change History (11)

comment:1 Changed 8 years ago by erikos

  • Cc walter godiard added
  • Summary changed from When changing the palettes using touch the tooltip stays to Radiotoolbutton: When changing the palettes using touch the tooltip stays

We should do the same as with the ToolButton and hide the tooltip on click. As there are still GTK2 activities (e.g. TA), this should probably be backported to toolkit-gtk2 as well.

diff --git a/src/sugar/graphics/radiotoolbutton.py b/src/sugar/graphics/radiotoolbutton.py
index b5fabf2..b882deb 100644
--- a/src/sugar/graphics/radiotoolbutton.py
+++ b/src/sugar/graphics/radiotoolbutton.py
@@ -180,3 +180,7 @@ class RadioToolButton(gtk.RadioToolButton):
                                   allocation.width, allocation.height)
 
         gtk.RadioToolButton.do_expose_event(self, event)
+
+    def do_clicked(self):
+        if self.palette:
+            self.palette.popdown(True)

Changed 8 years ago by erikos

patch for toolkit-gtk3 (same API as for the ToolButton)

comment:2 Changed 8 years ago by erikos

  • Keywords r? added

Attached the toolkit-gtk3 patch (testing with the list-view/favourites-view buttons in Home). The toolkit-gtk2 patch can be tested with TA: http://bugs.sugarlabs.org/ticket/4268#comment:1

Changed 8 years ago by erikos

toolkit-gtk2 patch (test with TA)

comment:3 follow-up: Changed 8 years ago by manuq

  • Keywords r+ added; r? removed

The gtk2 patch solves the issue in TA. With it the palettes are correctly displayed. Currently you need to taps to get them visible.

I tested the gtk3 patch with Abacus. The tooltip can be displayed with a long press, and a tap triggers the primary action. So is worth pushing too.

comment:4 in reply to: ↑ 3 Changed 8 years ago by manuq

Replying to manuq:

Currently you need to taps to get them visible.

s/to/two

comment:5 Changed 8 years ago by erikos

  • Resolution set to fixed
  • Status changed from new to closed

gtk2 fix: 344c72a3beb599b76f3ac806c34b7727a258530b

gtk3 fix: 5a1b380dd6099d7455d67e00718388fa79b57e01

comment:6 Changed 8 years ago by erikos

  • Keywords olpc-test-pending added

comment:7 Changed 8 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

Fixed in OLPC 13.1.0 os30 in both TurtleArt and Abacus, although the gtk2/gtk3 fixes behave slightly differently (the gtk2 version will recognize a touch on release if you do not move your finger after the tooltip appears; the gtk3 version will require an additional touch to click on the object after the tooltip appears).

comment:8 Changed 8 years ago by dnarvaez

  • Component changed from sugar-toolkit to Sugar

comment:9 Changed 8 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.