Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4262 closed defect (fixed)

Can not save/copy image

Reported by: erikos Owned by: manuq
Priority: Normal Milestone:
Component: Browse Version: 0.97.x
Severity: Major Keywords: regression
Cc: Distribution/OS: OLPC
Bug Status: Assigned

Description

When I do click on an image to save it, I only get the text Palette.

Change History (5)

comment:1 Changed 8 years ago by manuq

Works for me with right click and touch long press. This, if the image doesn't have a link. Tested with several images:

  • olpc logo and google logo in homepage of os15
  • Library: images in Images section
  • searched "sugar" in google images

Do you mean this should work with left click?

comment:2 Changed 8 years ago by erikos

  • Milestone changed from 0.98 to 1.0
  • Priority changed from High to Normal

Thanks Manuel for helping diagnosing this. You are right, if an image is a link as well we do not offer the keep image option in the Palette. The Palette would need to have both options then actually, for the link and the image.

Two examples here, that work under Firefox but not for us:

  • wiki.sugarlabs.org (the getting involved image on the landing page)

I actually doubt this has ever worked. Let's move this out to 1.0

comment:3 Changed 8 years ago by manuq

Excellent. So this are the states of an element of the page to display the palette:

http://webkitgtk.org/reference/webkitgtk/stable/WebKitHitTestResult.html#WebKitHitTestResultContext

I have checked they are not exclusive. For example SELECTION, IMAGE and LINK can all be True at the same time. Currently we have three palettes and we handle them in a exclusive way (if LINK.. link palette, else if IMAGE.. image palette, etc). I will work on this.

comment:4 Changed 8 years ago by manuq

  • Resolution set to fixed
  • Status changed from new to closed

Fix pushed. 6d61b433 c7316a89 9ecae185 . Will be in Browse 152.

comment:5 Changed 8 years ago by dnarvaez

  • Milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.