Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4246 closed defect (fixed)

Esc closes the pdf tab

Reported by: humitos Owned by: humitos
Priority: Normal Milestone:
Component: Browse Version: Unspecified
Severity: Unspecified Keywords: regression, r+, olpc-test-passed
Cc: manuq, greenfeld Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

Steps to reproduce it:

  1. Open Browse
  2. Type "pdf example" on the URL entry
  3. Click on the first result
  4. A new tab is opened
  5. Press Esc

Issue:

The PDF tab is closed

Expected behaviour:

Nothing should happen

Comment:

I get this error on the log:

1353330976.124008 DEBUG web-activity: keyboard: Stop loading
1353330976.124239 DEBUG root: Download PDF canceled
1353330976.124394 DEBUG root: Download error! code 0, detail 0: El usuario cancel�~C³ la descarga

Marked as regression. This don't happen in 12.1.0

Attachments (1)

0001-Avoid-close-the-PDFTab-when-Esc-is-pressed-SL-4246.patch (1.1 KB) - added by humitos 8 years ago.
This was introduce in: 41968d61. stop_loading for PDFTabPage does close the tab.

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by humitos

This was introduce in: 41968d61. stop_loading for PDFTabPage does close the tab.

comment:1 Changed 8 years ago by humitos

  • Cc manuq added
  • Keywords r? added

comment:2 Changed 8 years ago by manuq

I see. Good catch! Patch looks good too. Pushed 843faffb .

comment:3 Changed 8 years ago by humitos

  • Keywords r+ olpc-test-pending added; r? removed
  • Resolution set to fixed
  • Status changed from new to closed

comment:4 follow-up: Changed 8 years ago by greenfeld

I still see the PDF tab closed with this patch present in Browse-148 if I press ESC after clicking a PDF link but before the time the Web Browser has had time to fully download the file.

What exactly was fixed by this patch?

(Of note is that I'm slightly nervous about seeing relative (<=, <) comparisons made with enums or a flag field, but I presume you have double-checked this is acceptable.)

comment:5 in reply to: ↑ 4 Changed 8 years ago by humitos

  • Cc greenfeld added

Replying to greenfeld:

I still see the PDF tab closed with this patch present in Browse-148 if I press ESC after clicking a PDF link but before the time the Web Browser has had time to fully download the file.

This behaviour is correct.

What exactly was fixed by this patch?

This patch makes ESC to not close the pdf tab once it has fully downloaded. I mean, you click on a pdf link, wait until it finishes the download progress and there press ESC: without this patch Browse would close the Tab.

comment:6 Changed 8 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

ESC does not close the window after the PDF is fully downloaded in Browse-148.

comment:7 Changed 8 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.