Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#4231 closed defect (fixed)

Browse: trace in log

Reported by: humitos Owned by: humitos
Priority: Normal Milestone:
Component: Browse Version: Unspecified
Severity: Unspecified Keywords: r+, olpc-test-passed
Cc: manuq Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

Steps to reproduce it:

  1. Open Browse
  2. Go to Google
  3. Search for "pdf example"
  4. Open the first link
  5. Add a new tab
  6. Close the new tab opened

Issue:

This appears in the log

Traceback (most recent call last):
  File "/home/olpc/Activities/Browse.activity/webtoolbar.py", line 351, in __switch_page_cb
    self._connect_to_browser(tabbed_view.props.current_browser)
  File "/home/olpc/Activities/Browse.activity/webtoolbar.py", line 360, in _connect_to_browser
    address = self._browser.props.uri or self._browser.loading_uri
AttributeError: 'DummyBrowser' object has no attribute 'loading_uri'

Expected behaviour:

Do not fail

Environment:

XO-4 13.1.0 os11

This was reported here:

​http://bugs.sugarlabs.org/ticket/4187#comment:4

Attachments (1)

0001-Avoid-trace-in-log-for-PDF-tab-SL-4231.patch​ (1.4 KB) - added by humitos 11 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 11 years ago by godiard

  • Summary changed from Trace in Log to Brpwse: trace in log

Changed 11 years ago by humitos

comment:2 Changed 11 years ago by humitos

  • Cc manuq added
  • Keywords r? added
  • Summary changed from Brpwse: trace in log to Browse: trace in log

manuq: after applying this patch, take a look at #4187. Thanks.

comment:3 Changed 11 years ago by manuq

  • Keywords r+ olpc-test-pending added; r? removed
  • Resolution set to fixed
  • Status changed from new to closed

Great, pushed as 6578834b .

comment:4 Changed 10 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

The patch is present and this works in Browse-148/OLPC 13.1.0 os20.

comment:5 Changed 10 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.