#4230 closed defect (fixed)
Order of menu items in palette differs from Gecko version
| Reported by: | humitos | Owned by: | humitos |
|---|---|---|---|
| Priority: | Low | Milestone: | |
| Component: | Browse | Version: | Unspecified |
| Severity: | Minor | Keywords: | regression, r+, olpc-testing-pending |
| Cc: | garycmartin, erikos | Distribution/OS: | OLPC |
| Bug Status: | Unconfirmed |
Description
I was told that the order of the items in the palette shown when you longpress on a link differs from the Gecko version of Browse.
Take a look at the screenshots.
Attachments (3)
Change History (12)
Changed 11 years ago by humitos
Changed 11 years ago by humitos
comment:1 follow-up: ↓ 2 Changed 11 years ago by erikos
- Cc garycmartin added
- Priority changed from Normal to Low
- Severity changed from Unspecified to Minor
comment:2 in reply to: ↑ 1 ; follow-up: ↓ 3 Changed 11 years ago by garycmartin
Replying to erikos:
Gary, any specific order you favour?
I don't think there is a strong UI argument for a particular order here, but I would suggest going back to the original order to preserve existing documentation, screen shots, user memory. Don't change things we don't have a good reason for changing ;)
comment:3 in reply to: ↑ 2 Changed 11 years ago by erikos
Replying to garycmartin:
Replying to erikos:
Gary, any specific order you favour?
I don't think there is a strong UI argument for a particular order here, but I would suggest going back to the original order to preserve existing documentation, screen shots, user memory. Don't change things we don't have a good reason for changing ;)
Perfect, so Humitos, please get back to the old ordering. Thanks.
comment:4 Changed 11 years ago by humitos
- Owner changed from manuq to humitos
- Status changed from new to accepted
Changed 11 years ago by humitos
comment:5 Changed 11 years ago by humitos
- Cc erikos added
- Keywords regression r? added
comment:6 follow-up: ↓ 7 Changed 11 years ago by manuq
Thanks, patch looks good. What about the order of the palette for the images? Can you check if that one is inverted as well?
comment:7 in reply to: ↑ 6 Changed 11 years ago by humitos
Replying to manuq:
Thanks, patch looks good. What about the order of the palette for the images? Can you check if that one is inverted as well?
I've already checked that. It's correct
comment:8 Changed 11 years ago by erikos
- Keywords r+ olpc-testing-pending added; r? removed
- Resolution set to fixed
- Status changed from accepted to closed
Thanks, verified and pushed: http://git.sugarlabs.org/browse/mainline/commit/2d8178affd16026923c726c2164bb1e2783b8577
Gary, any specific order you favour?