Text selections should not be draggable via touch

[garycmartin]

Testing 13.1.0 build 11

Text selections should not be draggable via touch, it is very easy to accidentally move a text selection accidentally due to their usually large hit area, especially multiline selections and when using touch selection handles.

Test Case:
1) Start the Write Activity
2) Type some text
3) Make a selection (any way, keyboard, mouse, or touch)
4) touch and drag the selection with the touch screen

Result:
Text is dragged by touch screen interaction

Expectations:
No text drag should trigger, if the text view is scrollable I'd expect the interaction to scroll the view.

[garnacho]

very rough patch

[garnacho]

I've attached a quite crude patch that implements a touch interaction pattern similar to GtkScrolledWindow's, letting button events go through:

• if barely no motion happened in between
• after a timeout
• on a second tap around the same area

It's worth observing that *only* scrolling is implemented, there's no kinetic deceleration animation, nor overshooting. Text selection hasn't been disabled either, but just happens on the same terms than GtkTextViews under GtkScrolledWindows

[godiard]

Included in olpc6, this issue is solved.

[dnarvaez]

Milestone 0.98 deleted