#4216 closed defect (fixed)
Bookmarks doesn't go to the page that I bookmarked
| Reported by: | humitos | Owned by: | godiard |
|---|---|---|---|
| Priority: | High | Milestone: | |
| Component: | Read | Version: | Unspecified |
| Severity: | Unspecified | Keywords: | |
| Cc: | Distribution/OS: | Unspecified | |
| Bug Status: | Unconfirmed |
Description
Steps to reproduce it:
- Open a PDF with Read
- Scroll some pages
- Bookmark one
- Close Read
- Open the last instance of Read (it will open the recent closed book)
- Scroll some pages
- Click on the bookmark preview
Issue:
You are taken to the previous page that you bookmarked.
Expected behaviour:
Go to the same page that you bookmarked.
Environment:
XO-4 13.1.0 os11
Change History (6)
comment:1 Changed 11 years ago by godiard
comment:2 Changed 11 years ago by godiard
- Milestone changed from Unspecified by Release Team to 0.98
comment:3 Changed 11 years ago by godiard
- Keywords triage removed
comment:4 Changed 11 years ago by godiard
- Priority changed from Unspecified by Maintainer to High
comment:5 Changed 11 years ago by godiard
- Resolution set to fixed
- Status changed from new to closed
Pushed as 2f0b106eb5f4a126afbf02b757fdcc63ef5270bc
Note: See
TracTickets for help on using
tickets.
This part of Read code is not nice. The bookmarks are saved in the database with the page numbers zero based, but in the UI, of course the first page in the book is 1, no 0.
Then there are a few "+ 1" in different places and need be improved. Also we need check this works with the different backends (pdf, epub, text).