Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#4197 closed defect (fixed)

Read: in the epub index list, is impossible to tap on an arrow to unfold a sublist

Reported by: manuq Owned by: godiard
Priority: Normal Milestone:
Component: Read Version: Unspecified
Severity: Unspecified Keywords: r+, r?
Cc: humitos, erikos, godiard Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

TestCase:

  • use GetBooks to download an Epub with index of chapters, like "The Hunchback of Notre Dame"
  • open it with Read from the Journal
  • display the index using the list icon in the eye subtoolbar
  • try to tap an item with an ">" arrow

The arrows are 1. too close to the edge (similar to #4184) and 2. too small.

Proposal: make the whole row unfold the sublist as a first step.

Attachments (2)

0001-Expand-rows-on-tap-click-SL-4197.patch​ (1.7 KB) - added by humitos 11 years ago.
0001-Expand-rows-on-tap-click.patch​ (1.2 KB) - added by humitos 11 years ago.
A 5-minutes patch for Log

Download all attachments as: .zip

Change History (13)

comment:1 Changed 11 years ago by manuq

Also affects the tree view in View Source screen.

comment:2 Changed 11 years ago by manuq

View Source tracked at #4206 .

comment:3 Changed 11 years ago by godiard

  • Milestone changed from Unspecified by Release Team to 0.98

comment:4 Changed 11 years ago by godiard

  • Keywords triage removed

comment:5 Changed 11 years ago by godiard

  • Priority changed from Unspecified by Maintainer to Normal

Changed 11 years ago by humitos

comment:6 Changed 11 years ago by humitos

  • Cc humitos added
  • Keywords r? added

I've just uploaded a patch that expands/collapses the row when the user tap/click on it.

It's missing point 2): increase the size of the rows.

comment:7 Changed 11 years ago by manuq

The patch works as expected and the code looks right.

comment:8 Changed 11 years ago by erikos

  • Keywords r+ added; r? removed

If there is a 5 minute patch for log, it should be fixed there as well.

r+ from Manuel on this one.

Changed 11 years ago by humitos

A 5-minutes patch for Log

comment:9 Changed 11 years ago by humitos

  • Cc erikos godiard added
  • Keywords r? added

I've just attached a version of this bugfix for Log Activity.

comment:10 Changed 11 years ago by godiard

  • Resolution set to fixed
  • Status changed from new to closed

Thanks. Changes included in Read 106 and Log 32

comment:11 Changed 11 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.