Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4196 closed enhancement (fixed)

Padding on help palette

Reported by: humitos Owned by: humitos
Priority: Low Milestone:
Component: Terminal Version: Unspecified
Severity: Unspecified Keywords: r+, olpc-test-pending
Cc: humitos, danielfrancis, aguz Distribution/OS: OLPC
Bug Status: Resolved

Description (last modified by humitos)

It would be great to add some left-padding to the help shown in the Help Palette.

Attachments (3)

left padding.png (57.2 KB) - added by humitos 8 years ago.
0001-Left-padding-on-help-palette-SL-4196.patch (793 bytes) - added by humitos 8 years ago.
Patch for "origin/gtk3" branch
0001-Padding-on-help-palette-SL-4196.patch (787 bytes) - added by humitos 8 years ago.
v2 - git message changed - Patch for "origin/gtk3" branch

Download all attachments as: .zip

Change History (12)

Changed 8 years ago by humitos

comment:1 Changed 8 years ago by humitos

  • Type changed from defect to enhancement

comment:2 Changed 8 years ago by humitos

  • Owner changed from RafaelOrtiz to humitos
  • Status changed from new to accepted

comment:3 Changed 8 years ago by humitos

  • Description modified (diff)

This is what we need: helpbutton.py

self._vbox.set_border_width(10)

Changed 8 years ago by humitos

Patch for "origin/gtk3" branch

comment:4 Changed 8 years ago by humitos

  • Cc aguz added
  • Keywords r? added

Guys, can you review this patch and push it if it's ok? Thanks

Changed 8 years ago by humitos

v2 - git message changed - Patch for "origin/gtk3" branch

comment:5 Changed 8 years ago by danielfrancis

  • Bug Status changed from Unconfirmed to Resolved

Thanks, pushed.
I don't care about the git message.

http://git.sugarlabs.org/terminal/mainline/commit/6879f4c7c9ff1b73f4d0ffa1f8936f89a51e5b36

I wait for a testcase (maybe aguz) and if not, I close it when your change land in ASLO.

comment:6 Changed 8 years ago by humitos

  • Keywords r+ olpc-test-pending added; r? removed

comment:7 Changed 8 years ago by manuq

  • Resolution set to fixed
  • Status changed from accepted to closed

comment:8 Changed 8 years ago by manuq

We close the tickets after the fix is pushed. Thanks.

comment:9 Changed 8 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.