Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4190 closed defect (fixed)

Journal scrolling: there is sometimes a grey rectagle where your finger touched

Reported by: erikos Owned by: manuq
Priority: High Milestone:
Component: Sugar Version: 0.97.x
Severity: Major Keywords: r+, olpc-test-passed
Cc: humitos, erikos Distribution/OS: Unspecified
Bug Status: Assigned

Description

Build: os11

Steps to reproduce:

  • open the Journal
  • scroll with touch

Change History (15)

comment:1 Changed 8 years ago by erikos

Check that is has nothing to do with #4068

Changed 8 years ago by humitos

comment:2 Changed 8 years ago by humitos

  • Cc humitos added

Some builds ago I was able to click on those rectangles with the touchpad and make them activated (it changed the color to a darker one while I was hovering it after clicking)

comment:3 Changed 8 years ago by erikos

  • Bug Status changed from Unconfirmed to Assigned
  • Keywords triage removed
  • Milestone changed from Unspecified by Release Team to 0.98
  • Priority changed from Unspecified by Maintainer to High
  • Severity changed from Unspecified to Major
  • Version changed from Unspecified to 0.97.x

Regression from the press/hover feedback work. Should be fixed before 0.98.0

comment:4 Changed 8 years ago by manuq

This are the buddy cell renderer icons, which have no image when the activity was not shared but they have the prelight feedback.

Changed 8 years ago by manuq

Proposed patch.

comment:5 Changed 8 years ago by manuq

  • Cc erikos added
  • Keywords r? added

comment:6 Changed 8 years ago by erikos

  • Keywords r- added; r? removed

As discussed on irc, assigning the set_cell_data_func for the column is the better approach.

comment:7 Changed 8 years ago by manuq

Yes, good point Simon. Changing the cell visibility in the set_cell_data_func callback is the proper solution. Then this has a dependency on what we decide for #3888 . I will add two patches, one for the workaround in #3888 and one for the still unfinished patch in the same ticket.

comment:8 Changed 8 years ago by manuq

  • Keywords r? added; r- removed

comment:9 Changed 8 years ago by manuq

  • Keywords r+ olpc-test-pending added; r? removed
  • Resolution set to fixed
  • Status changed from new to closed

Pushed dc6851d4 .

comment:10 Changed 8 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

There are no grey rectangles where there are no buddies in 13.1.0 os20/Sugar 0.98.2.

comment:11 Changed 8 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.