Context Navigation

← Previous Ticket
Next Ticket →

#4190 closed defect (fixed)

Journal scrolling: there is sometimes a grey rectagle where your finger touched

Reported by:	erikos	Owned by:	manuq
Priority:	High	Milestone:
Component:	Sugar	Version:	0.97.x
Severity:	Major	Keywords:	r+, olpc-test-passed
Cc:	humitos, erikos	Distribution/OS:	Unspecified
Bug Status:	Assigned

Description

Build: os11

Steps to reproduce:

open the Journal

scroll with touch

Attachments (4)

Screenshot of _Journal_.png (63.1 KB) - added by humitos 10 years ago.
0001-CellRendererIcon-Skip-drawing-if-the-icon-is-empty-S.patch (1.5 KB) - added by manuq 10 years ago.: Proposed patch.
0002-Journal-list-view-make-buddy-cells-invisible-if-the-.patch (1.1 KB) - added by manuq 10 years ago.: Patch that goes after http://bugs.sugarlabs.org/attachment/ticket/3888/0001-Change-Journal-model-to-make-the-buddy-icons-work.patch
0002-Journal-list-view-make-buddy-cells-invisible-if-the-.2.patch (1.2 KB) - added by manuq 10 years ago.: Patch that goes after http://bugs.sugarlabs.org/attachment/ticket/3888/0001-Journal-list-call-do_get_value-directly-to-get-the-b.patch

Download all attachments as: .zip

Change History (15)

comment:1 Changed 10 years ago by erikos

Check that is has nothing to do with #4068

Changed 10 years ago by humitos

Attachment Screenshot of _Journal_.png added

comment:2 Changed 10 years ago by humitos

Cc humitos added

Some builds ago I was able to click on those rectangles with the touchpad and make them activated (it changed the color to a darker one while I was hovering it after clicking)

comment:3 Changed 10 years ago by erikos

Bug Status changed from Unconfirmed to Assigned
Keywords triage removed
Milestone changed from Unspecified by Release Team to 0.98
Priority changed from Unspecified by Maintainer to High
Severity changed from Unspecified to Major
Version changed from Unspecified to 0.97.x

Regression from the press/hover feedback work. Should be fixed before 0.98.0

comment:4 Changed 10 years ago by manuq

This are the buddy cell renderer icons, which have no image when the activity was not shared but they have the prelight feedback.

Changed 10 years ago by manuq

Attachment 0001-CellRendererIcon-Skip-drawing-if-the-icon-is-empty-S.patch added

Proposed patch.

comment:5 Changed 10 years ago by manuq

Cc erikos added
Keywords r? added

comment:6 Changed 10 years ago by erikos

Keywords r- added; r? removed

As discussed on irc, assigning the set_cell_data_func for the column is the better approach.

comment:7 Changed 10 years ago by manuq

Yes, good point Simon. Changing the cell visibility in the set_cell_data_func callback is the proper solution. Then this has a dependency on what we decide for #3888 . I will add two patches, one for the workaround in #3888 and one for the still unfinished patch in the same ticket.