Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4188 closed defect (fixed)

Frame, wireless device icon: coloring is not always accurate (grey icon outlines)

Reported by: erikos Owned by: erikos
Priority: Normal Milestone:
Component: Sugar Version: 0.97.x
Severity: Major Keywords: regression, r+
Cc: humitos, erikos, manuq Distribution/OS: OLPC
Bug Status: Assigned

Description (last modified by humitos)

Build: os11

Steps to reproduce:

  • connect to an access point
  • reveal the frame and check the status of the wireless device icon

---> the icon has sometimes just the grey outline, no colour


I found a test case:

  1. Go to neighborhood
  2. Reveal the frame
  3. Click to connect to a known wifi network
  4. Click to connect to an unknown wifi network (in my case with password)
  5. Click on cancel
  6. Wait for a moment

At some point, Sugar will try to connect again with the known wifi and after that the icon in the frame will be in the uncolored state.

Attachments (4)

Screenshot of _Terminal Activity_.png (86.7 KB) - added by humitos 8 years ago.
0001-Wireless-Device-icon-use-the-same-status-code-as-the.patch (1.4 KB) - added by erikos 8 years ago.
Wireless Device icon: use the same status code as the newtworkview has
0002-Wireless-Device-icon-use-the-same-status-code-as-the.patch (2.1 KB) - added by manuq 8 years ago.
Updated patch.
0001-Frame-Wireless-Device-icon-use-the-same-status-code-.patch (2.0 KB) - added by erikos 8 years ago.
Updated patch: move the update_color code before the update_state call

Download all attachments as: .zip

Change History (19)

comment:1 Changed 8 years ago by erikos

I have seen this on the XO-4 (ebook mode) and the 1.75-touch where I did the connection with the mouse. On another XO 1.75 the icon was coloured correctly.

Changed 8 years ago by humitos

comment:2 Changed 8 years ago by humitos

  • Cc humitos added

The screenshot was taken on XO-4 os11 (without ebook mode enabled)

comment:3 Changed 8 years ago by erikos

  • Bug Status changed from Unconfirmed to Assigned
  • Distribution/OS changed from Unspecified to OLPC
  • Keywords triage removed
  • Milestone changed from Unspecified by Release Team to 0.98
  • Priority changed from Unspecified by Maintainer to High
  • Severity changed from Unspecified to Major
  • Version changed from Unspecified to 0.97.x

Seen this on too many machines now. Is important to fix in 0.98 and a regression.

comment:4 Changed 8 years ago by erikos

  • Keywords regression added

Changed 8 years ago by erikos

Wireless Device icon: use the same status code as the newtworkview has

comment:5 Changed 8 years ago by erikos

  • Keywords r? added

comment:6 Changed 8 years ago by erikos

The badge of the icon is not correct, but that is not a regression to 12.1.0, was the same there.

comment:7 Changed 8 years ago by humitos

  • Description modified (diff)

comment:8 Changed 8 years ago by humitos

  • Cc erikos added
  • Keywords r- added; r? removed

@erikos: I've just tested your patch and it did not pass the test case that I added to the description.

Changed 8 years ago by manuq

Updated patch.

comment:9 follow-up: Changed 8 years ago by manuq

  • Keywords r? added; r- removed

Added update_color, also as WirelessNetworkView does, is working for me. Please test.

comment:10 in reply to: ↑ 9 Changed 8 years ago by humitos

  • Cc manuq added

Replying to manuq:

Added update_color, also as WirelessNetworkView does, is working for me. Please test.

It works in some way. This patch seems to fix the issue regarding the uncolored state after a successful connection, but after that if I click on "Disconnect" I get the simple circle with colors saying "No wireless connection" instead the gray one.

comment:11 Changed 8 years ago by godiard

  • Priority changed from High to Normal

Changed 8 years ago by erikos

Updated patch: move the update_color code before the update_state call

comment:12 follow-up: Changed 8 years ago by erikos

The latest patch fixes the issue humitos described in his last comment. In the Disconnected state in 'update_state' we do set the colour of the icon to inactive/grey if we call 'update_color' after that we set it again to the cached AP colour.

comment:13 in reply to: ↑ 12 Changed 8 years ago by manuq

  • Keywords r+ added; r? removed

Replying to erikos:

The latest patch fixes the issue humitos described in his last comment. In the Disconnected state in 'update_state' we do set the colour of the icon to inactive/grey if we call 'update_color' after that we set it again to the cached AP colour.

Yes, moving that line up makes it work, great Simon. Please push.

comment:14 Changed 8 years ago by erikos

  • Resolution set to fixed
  • Status changed from new to closed

master: 976c3f5ef1202d586f65d90d959d123d33d70e07 0.98: 2571db3ace84f0240f55e332aab5c3df7c5f23c7

comment:15 Changed 8 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.