Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4177 closed defect (duplicate)

Wireless password dialogue OK button incorrectly themed

Reported by: garycmartin Owned by: manuq
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: 0.97.x
Severity: Unspecified Keywords: 13.1.0
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description (last modified by garycmartin)

Wireless password dialogue 'OK' button is incorrectly themed. The colour and icon look fine, but the text that is missing or is same colour as background. The 'Cancel' button seems fine.

Attachments (1)

wireless_key_dialogue_missing_icon.png (43.4 KB) - added by garycmartin 8 years ago.

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by garycmartin

comment:1 Changed 8 years ago by garycmartin

  • Description modified (diff)

comment:2 follow-up: Changed 8 years ago by manuq

Yes that's #4172, already with a patch. Can you test applying the patch to artwork? Thanks for the report!

comment:3 in reply to: ↑ 2 Changed 8 years ago by garycmartin

Replying to manuq:

Yes that's #4172, already with a patch. Can you test applying the patch to artwork? Thanks for the report!

Thanks. Have just tested it. The button (insensitive state) now shows up as white background with the OK text in grey, this looks incorrect for the black dialogue style as it looks like the button is more active than the actual active state. Suggest the insensitive state for this dialogue should be black with grey text. This would be similar to the old un-themed dialogue that used a grey dialogue fill, and showed inactive buttons as grey fill with darker grey text and buttons.

Apologies that this obviously is a complication for the #4172 case, where the intro screen background is white, and the inactive button state should be white fill with grey text and icon.

comment:4 Changed 8 years ago by manuq

You are right! No need to apoligize :) I also want the proper solution. Added a new patch to #4172 with testcase.

comment:5 Changed 8 years ago by manuq

  • Resolution set to duplicate
  • Status changed from new to closed

Dup of #4172

comment:6 Changed 8 years ago by dnarvaez

  • Component changed from sugar-artwork to Sugar

comment:7 Changed 8 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.