Opened 7 years ago

Closed 3 years ago

Last modified 3 years ago

#4172 closed defect (fixed)

Set color of insensitive buttons

Reported by: manuq Owned by: manuq
Priority: High Milestone: Unspecified
Component: Sugar Version: Unspecified
Severity: Major Keywords: r+, olpc-test-passed
Cc: erikos, garycmartin Distribution/OS: Unspecified
Bug Status: Resolved

Description

The greyed-out "Next" button on the intro screen comes up with the text in the same colour as the background, i.e. you cant see it.

Attachments (4)

0001-Remove-rule-for-inexistent-class-.window.patch (996 bytes) - added by manuq 7 years ago.
Cleanup patch, while I'm on it.
0002-Style-insensitive-state-of-buttons-SL-4172.patch (978 bytes) - added by manuq 7 years ago.
Fix.
0002-Add-insensitive-button-to-buttons-testcase-SL-4172.patch (1.1 KB) - added by manuq 7 years ago.
Add insensitive button to buttons testcase.
0002-Style-insensitive-state-of-buttons-SL-4172.2.patch (1.2 KB) - added by manuq 7 years ago.
v2 of the artwork patch, make the background of insensitive buttons transparent

Download all attachments as: .zip

Change History (23)

Changed 7 years ago by manuq

Cleanup patch, while I'm on it.

comment:1 Changed 7 years ago by manuq

  • Cc erikos added
  • Keywords r? added

The icon inside the button will be fixed in #3974.

Changed 7 years ago by manuq

Add insensitive button to buttons testcase.

Changed 7 years ago by manuq

v2 of the artwork patch, make the background of insensitive buttons transparent

comment:2 Changed 7 years ago by manuq

Added v2 that takes into account Gary's considerations in #4177 . It seems that setting the background of insensitive buttons to transparent works for all cases.

TestCases:

Test in white canvas, like in the intro screen:

  • run tests/graphics/intro.py
  • go to previus and delete the nick name
  • see the inactive button
  • to close the test you can use xkill command

Test in a normal activity canvas, with panel_grey background:

  • run tests/graphics/buttons.py with the toolkit patch attached in this ticket applied
  • see the inactive button

Test in black canvas, like in the wireless password dialog:

  • run testdialog.py
  • click on the button, dialog appears
  • see the inactive button

comment:3 Changed 7 years ago by manuq

  • Priority changed from Unspecified by Maintainer to High
  • Severity changed from Unspecified to Major

comment:4 Changed 7 years ago by manuq

  • Cc garycmartin added
  • Keywords r+ olpc-test-pending added; r? removed
  • Resolution set to fixed
  • Status changed from new to closed

comment:5 Changed 7 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

Inactive/insensitive buttons look reasonable in Sugar 0.98.2/0.98.3.

comment:6 Changed 6 years ago by dnarvaez

  • Component changed from sugar-artwork to Sugar

comment:7 Changed 6 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

comment:8 Changed 5 years ago by godiard

  • Milestone set to Unspecified
  • Resolution fixed deleted
  • Status changed from closed to reopened

In some way, we regresed, the icon is not visible on 0.102 in the intro screens when the button are disabled

comment:9 Changed 4 years ago by tch

Still present in 0.107.0.

comment:11 Changed 4 years ago by venky18

@SAMdroid is this issue fixed ?

comment:12 Changed 4 years ago by quozl

  • Resolution set to fixed
  • Status changed from reopened to closed

The symptom as described does not occur with Sugar 0.108 in Fedora 18, 20, or 23, Ubuntu 14.04, 14.10, 15.04, 15.10 or 16.04.

comment:13 Changed 4 years ago by SAMdroid

Still a bug for gtk320. But gtk320 is a different story completely. Please look at this patch I beg you

https://github.com/sugarlabs/sugar-artwork/pull/88

comment:14 Changed 4 years ago by quozl

  • Resolution fixed deleted
  • Status changed from closed to reopened

Thanks. I don't understand the patch and can't test it easily, but I'll nudge your release engineer. ;-)

comment:15 Changed 3 years ago by Himanshu786

  • Bug Status changed from Unconfirmed to Resolved
  • Resolution set to fixed
  • Status changed from reopened to closed

There is no bug founded during the testing of Sugar-build.The css file is correct and the link is https://github.com/sugarlabs/sugar-artwork/pull/88/files .Now the issue is resolved.See like https://drive.google.com/open , https://drive.google.com/open , https://drive.google.com/open , https://drive.google.com/open

comment:16 Changed 3 years ago by Himanshu786

There is no bug founded during the testing of Sugar-build.The css file is correct and the link is https://github.com/sugarlabs/sugar-artwork/pull/88/files .I think the issue is resolved.See like https://drive.google.com/open , https://drive.google.com/open , https://drive.google.com/open , https://drive.google.com/open

comment:17 Changed 3 years ago by Himanshu786

There is no bug founded during the testing of Sugar-build.The css file is correct and the link is https://github.com/sugarlabs/sugar-artwork/pull/88/files

comment:18 Changed 3 years ago by Himanshu786

There is no bug founded during the testing of Sugar-build.The css file is correct and the link is https://github.com/sugarlabs/sugar-artwork/pull/88/files

comment:19 Changed 3 years ago by ignacio

Confirmed, no longer present in F25, Gtk 3.22

Note: See TracTickets for help on using tickets.