Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4160 closed defect (fixed)

DescriptionButton in activity toolbar: text not visible

Reported by: erikos Owned by: manuq
Priority: High Milestone:
Component: Sugar Version: 0.97.x
Severity: Major Keywords: olpc-test-passed
Cc: Distribution/OS: OLPC
Bug Status: Assigned

Description

The text in a Palette is themed as white by default.

Possible fix:

diff --git a/gtk3/theme/gtk-widgets.css.em b/gtk3/theme/gtk-widgets.css.em
index 9bd6d01..f4b6c75 100644
--- a/gtk3/theme/gtk-widgets.css.em
+++ b/gtk3/theme/gtk-widgets.css.em
@@ -407,6 +407,10 @@ SugarPaletteWindowWidget {
     color: @white;
 }
 
+SugarPaletteWindowWidget .view {
+    color: @black;
+}
+

Change History (5)

comment:1 Changed 8 years ago by manuq

Good catch!

This was regressed in b2b0f261 "Style insensitive text - SL #4139", when I removed the color rule from .view {} . I think that change is good and palettes should set it, as your patch does. Please push.

comment:2 Changed 8 years ago by erikos

  • Keywords olpc-test-pending added
  • Resolution set to fixed
  • Status changed from new to closed

Pushed as 599c6730decba9c36dab4949dcb4d350898bc12d

comment:3 Changed 8 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

I have not noticed any oddly colored text in activities for the past few months, and I believe all the kludges we had added to various activities to theme themselves better were removed.

comment:4 Changed 8 years ago by dnarvaez

  • Component changed from sugar-artwork to Sugar

comment:5 Changed 8 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.