#4144 closed defect (fixed)
Style custom Palettes
Reported by: | erikos | Owned by: | manuq |
---|---|---|---|
Priority: | High | Milestone: | |
Component: | Sugar | Version: | 0.97.x |
Severity: | Major | Keywords: | r+, olpc-test-passed |
Cc: | erikos | Distribution/OS: | OLPC |
Bug Status: | Assigned |
Description
(see Home View)
- there should be a minimum size for the Palettes
- the entries should fill all the horizontal space (see old school Activity Palette in the Journal)
- the horizontal (separator) line at the bottom should go all across
- insensitive items (see Speak Palette in the frame device)
Attachments (5)
Change History (14)
Changed 11 years ago by manuq
Changed 11 years ago by manuq
Toolkit patch, correct size and paddings for palette window implementation
comment:1 Changed 11 years ago by manuq
- Cc erikos added
- Keywords r? added
The three patches above get back the palettes layout to normal.
comment:2 Changed 11 years ago by manuq
The two new patches improve the API so the implementation details of adding items in menus are hidden to the consumer, like the shell palettes.
comment:3 Changed 11 years ago by manuq
Two issues still:
- the separators are thinner than in 12.1.0, maybe because of cairo rendering (width number is the same)
- the outline border of the menu dissapears when an item is hovered
comment:4 follow-up: ↓ 5 Changed 11 years ago by erikos
Thanks Manuel for the patches, looks already much improved to me. If Gary is convinced that we should not go for 3 grid cells as a minimum keep it at the 2 cells minimum.
comment:5 in reply to: ↑ 4 Changed 11 years ago by garycmartin
Replying to erikos:
Thanks Manuel for the patches, looks already much improved to me. If Gary is convinced that we should not go for 3 grid cells as a minimum keep it at the 2 cells minimum.
Thanks, I'm good with the 3 grid cells minimum. FWIW the first patch with 4 grid cells was particularly strange looking in some places due to the excessive blank empty space in palettes that only had short content (Group and Home palette hints, Activity palettes with short names etc).
comment:6 Changed 11 years ago by manuq
- Keywords r+ olpc-test-pending added; r? removed
- Resolution set to fixed
- Status changed from new to closed
Thanks Gary and Simon for the feedback. Pushed toolkit 5505eb30 and shell 798548f8 .
comment:7 Changed 11 years ago by greenfeld
- Keywords olpc-test-passed added; olpc-test-pending removed
In general the various palettes/menus throughout Sugar look reasonable and have for a while.
Looked at in Sugar 0.98.2 & .3.
comment:8 Changed 10 years ago by dnarvaez
- Component changed from sugar-toolkit-gtk3 to Sugar
Toolkit patch for the insensitive items.