Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4144 closed defect (fixed)

Style custom Palettes

Reported by: erikos Owned by: manuq
Priority: High Milestone:
Component: Sugar Version: 0.97.x
Severity: Major Keywords: r+, olpc-test-passed
Cc: erikos Distribution/OS: OLPC
Bug Status: Assigned

Description

(see Home View)

  • there should be a minimum size for the Palettes
  • the entries should fill all the horizontal space (see old school Activity Palette in the Journal)
  • the horizontal (separator) line at the bottom should go all across
  • insensitive items (see Speak Palette in the frame device)

Attachments (5)

0001-Palette-Menu-Item-set-unset-INSENSITIVE-state-flag-S.patch (2.3 KB) - added by manuq 8 years ago.
Toolkit patch for the insensitive items.
0002-Set-correct-padding-and-size-for-the-palette-window-.patch (4.6 KB) - added by manuq 8 years ago.
Toolkit patch, correct size and paddings for palette window implementation
0001-Embed-menu-items-in-PaletteMenuItemCustom-containers.patch (8.3 KB) - added by manuq 8 years ago.
Shell patch to fix the palettes with custom items.
0001-Palettes-adjust-to-the-new-API-SL-4144.patch (18.2 KB) - added by manuq 8 years ago.
New artwork patch.
0001-Set-correct-padding-and-size-for-the-palette-window-.patch (15.2 KB) - added by manuq 8 years ago.
New toolkit patch.

Download all attachments as: .zip

Change History (14)

Changed 8 years ago by manuq

Toolkit patch for the insensitive items.

Changed 8 years ago by manuq

Toolkit patch, correct size and paddings for palette window implementation

comment:1 Changed 8 years ago by manuq

  • Cc erikos added
  • Keywords r? added

The three patches above get back the palettes layout to normal.

Changed 8 years ago by manuq

Shell patch to fix the palettes with custom items.

comment:2 Changed 8 years ago by manuq

The two new patches improve the API so the implementation details of adding items in menus are hidden to the consumer, like the shell palettes.

comment:3 Changed 8 years ago by manuq

Two issues still:

  • the separators are thinner than in 12.1.0, maybe because of cairo rendering (width number is the same)
  • the outline border of the menu dissapears when an item is hovered

Changed 8 years ago by manuq

New artwork patch.

Changed 8 years ago by manuq

New toolkit patch.

comment:4 follow-up: Changed 8 years ago by erikos

Thanks Manuel for the patches, looks already much improved to me. If Gary is convinced that we should not go for 3 grid cells as a minimum keep it at the 2 cells minimum.

comment:5 in reply to: ↑ 4 Changed 8 years ago by garycmartin

Replying to erikos:

Thanks Manuel for the patches, looks already much improved to me. If Gary is convinced that we should not go for 3 grid cells as a minimum keep it at the 2 cells minimum.

Thanks, I'm good with the 3 grid cells minimum. FWIW the first patch with 4 grid cells was particularly strange looking in some places due to the excessive blank empty space in palettes that only had short content (Group and Home palette hints, Activity palettes with short names etc).

comment:6 Changed 8 years ago by manuq

  • Keywords r+ olpc-test-pending added; r? removed
  • Resolution set to fixed
  • Status changed from new to closed

Thanks Gary and Simon for the feedback. Pushed toolkit 5505eb30 and shell 798548f8 .

comment:7 Changed 8 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

In general the various palettes/menus throughout Sugar look reasonable and have for a while.

Looked at in Sugar 0.98.2 & .3.

comment:8 Changed 8 years ago by dnarvaez

  • Component changed from sugar-toolkit-gtk3 to Sugar

comment:9 Changed 8 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.