Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#4106 closed defect (fixed)

Naming a photo with OSK: osk does cover the entry

Reported by: erikos Owned by: godiard
Priority: High Milestone:
Component: Record Version: 0.97.x
Severity: Major Keywords: r? olpc-test-passed
Cc: dsd Distribution/OS: OLPC
Bug Status: Assigned

Description

Build: os8

Steps to reproduce:

  • on the XO run Record in ebook mode
  • take a photo
  • name it

---> the osk will cover the entry

Attachments (1)

0001-Move-title-widget-to-the-top-to-enable-use-with-osk-.patch (4.9 KB) - added by godiard 7 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 7 years ago by garycmartin

Moving the Title: input area to the top of the screen above the photo is a good work around here, should look fine as well.

comment:2 Changed 7 years ago by erikos

  • Bug Status changed from Unconfirmed to Assigned
  • Owner changed from dsd to gonzalo
  • Status changed from new to assigned
dsd: gary says its ok as a workaround, what would the real fix be?
erikos: dsd: I was guessing that, that is why I am asking
erikos: dsd: if Record would be gtk3-ported one could look at the osk-im-position part that we want to land
dsd: how would it behave in that situation?
erikos: dsd: move up, that the entry is visible
dsd: ok cool, that will be something that just magically happens?
erikos: dsd: there should be at least osk_height space below and above the canvas
erikos: dsd: yes
erikos: dsd: taken care by the toolkit
dsd: ok sounds good

comment:3 Changed 7 years ago by godiard

  • Owner changed from gonzalo to godiard

comment:4 Changed 7 years ago by godiard

As Record is gtk2, implemented the title entry at top option.

comment:5 Changed 7 years ago by godiard

Testing the previous patch I have found http://dev.laptop.org/ticket/11821 and also http://dev.laptop.org/ticket/12338

comment:6 Changed 7 years ago by godiard

  • Cc dsd added

comment:7 Changed 7 years ago by godiard

  • Keywords r? added

comment:8 follow-up: Changed 7 years ago by garycmartin

Tested the patch on Record-96 running on an XO-1.75 and is working well, thanks! :) Took a number of photos, renamed them via the OSK, Stopped to check the names had taken correctly, resumed and checked again.

FWIW: Was a little confused when trying to rename video recordings – you need to tap the 'i' icon, if you can, and the Title field is shown there with the other metadata description field. Need to look at this in another cycle I think to tidy up the design.

comment:9 in reply to: ↑ 8 Changed 7 years ago by godiard

Replying to garycmartin:

FWIW: Was a little confused when trying to rename video recordings – you need to tap the 'i' icon, if you can, and the Title field is shown there with the other metadata description field. Need to look at this in another cycle I think to tidy up the design.

Yes, next cycle we need review Record UI

comment:10 Changed 7 years ago by dsd

  • Keywords olpc-test-pending added
  • Resolution set to fixed
  • Status changed from assigned to closed

I don't like the way this makes the UI jump around (previously it was more consistent, with the controls always below the image). It feels a bit disorientating to the user as well.

But Simon asked that we include this anyway, in the interests of the on screen keyboard, and with the idea that we revert it later when moving to GTK3 and having a more generic solution available to the OSK-obscures-widget problem. Will be included in Record-97.

comment:11 Changed 7 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

The title and tag fields are raised for OSK usage in Record-97.

comment:12 Changed 6 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.