#4101 closed defect (fixed)
Source View: Trace when we try to 'set_parent_tansient_for'
Reported by: | erikos | Owned by: | erikos |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | Sugar | Version: | 0.97.x |
Severity: | Major | Keywords: | 13.1.0, r+, olpc-test-passed |
Cc: | humitos | Distribution/OS: | OLPC |
Bug Status: | Assigned |
Description
Trace:
Traceback (most recent call last): File "/home/erikos/sugar-build/install/lib/python2.7/site-packages/jarabe/view/viewsource.py", line 208, in __realize_cb self.set_transient_for(parent) File "/home/erikos/sugar-build/install/lib/python2.7/site-packages/gi/types.py", line 47, in function return info.invoke(*args, **kwargs) TypeError: argument parent: Expected Gtk.Window, but got gi.repository.GdkX11.X11Window
Previously we did:
>>> import gtk >>> w = gtk.Window() >>> gtk.gdk.window_foreign_new(w.window.xid) <gtk.gdk.Window object at 0xb7699a7c (GdkWindow at 0x8608b10)>
Now we do:
>>> from gi.repository import GdkX11 >>> from gi.repository import Gdk >>> display = Gdk.Display.get_default() >>> GdkX11.X11Window.foreign_new_for_display(display, 39845891L) <X11Window object at 0xb7660a04 (GdkX11Window at 0x8c511f8)>
Attachments (1)
Change History (7)
Changed 11 years ago by humitos
comment:1 Changed 11 years ago by humitos
- Keywords r? added
comment:2 Changed 11 years ago by humitos
- Cc humitos added
comment:3 Changed 11 years ago by erikos
Please be more verbose on the fix in the patch.
comment:4 Changed 11 years ago by erikos
- Keywords 13.1.0 r+ olpc-test-pending added; r? removed
- Resolution set to fixed
- Status changed from new to closed
Pushed: http://git.sugarlabs.org/sugar/mainline/commit/7f46bb3dbaf514b18d6cb567f54ce95fb674ad93
Thanks for the patch
comment:5 Changed 10 years ago by greenfeld
- Keywords olpc-test-passed added; olpc-test-pending removed
I do not see this traceback in the view source dialog in OLPC 13.1.0 os30
Note: See
TracTickets for help on using
tickets.
A proposal patch to avoid the Traceback