Opened 11 years ago
Last modified 9 years ago
#4098 assigned defect
FavoritesView: icon offset
Reported by: | erikos | Owned by: | manuq |
---|---|---|---|
Priority: | Low | Milestone: | Unspecified |
Component: | Sugar | Version: | 0.97.x |
Severity: | Minor | Keywords: | regression, r- |
Cc: | erikos | Distribution/OS: | Unspecified |
Bug Status: | Unconfirmed |
Description
There are a few visual glitches:
- the first icon in the spiral (e.g. Abacus) is not centred over the owner icon
- the distance between the icons below the owner icon and above is bigger
Attachments (1)
Change History (10)
comment:1 Changed 11 years ago by erikos
comment:2 Changed 11 years ago by garycmartin
- Cc manuq added
Thanks Simon, sorry I should have filed this earlier. It was already present before my updated spiral touch layout patch. I spent time trying to hunt down what was causing it. My best guess is this was introduced with the new (much large) rounded rect hover/press style, the extra icon padding looks to be being excluded from the width/height icon centre calculations, but included in the actual placement, so they all end up (for a ~40 icon spiral) about 10px to the right and down of where they should be.
comment:3 Changed 11 years ago by manuq
- Owner changed from garycmartin to manuq
- Status changed from new to assigned
Yes, the bug was there in the outline hover feedback too, but less noticeable. We have now enlarged the border [1]. The proper fix is consider this border in the spiral layout calculations.
[1] http://git.sugarlabs.org/sugar/mainline/commit/9b3c453970ef923f833d8257491b2c5de4303591
comment:4 Changed 11 years ago by manuq
- Keywords regression added
comment:5 Changed 11 years ago by manuq
- Priority changed from Unspecified by Maintainer to Normal
- Severity changed from Unspecified to Minor
comment:6 Changed 11 years ago by manuq
- Cc erikos added; manuq removed
- Keywords r? added
comment:7 Changed 11 years ago by erikos
- Keywords r- added; r? removed
There is an issue with this patch: when you start Sugar the icon positions get recalculated and then you see a shift afterwards. It should be correctly recalculated right away.
(tested with sugar-build master and the patch from #3925)
comment:8 Changed 10 years ago by dnarvaez
- Milestone changed from 0.98 to Unspecified
comment:9 Changed 9 years ago by godiard
- Priority changed from Normal to Low
build: (os8)