#4065 closed defect (fixed)
Frame: device icons: icons should act as toggles on left mouse click ot tap, popup/popdown Palette
Reported by: | erikos | Owned by: | erikos |
---|---|---|---|
Priority: | High | Milestone: | |
Component: | Sugar | Version: | 0.97.x |
Severity: | Major | Keywords: | palettes, r+, olpc-test-passed |
Cc: | manuq | Distribution/OS: | OLPC |
Bug Status: | Assigned |
Description
Attachments (6)
Change History (14)
Changed 10 years ago by erikos
comment:1 Changed 10 years ago by erikos
- Cc manuq added
- Keywords r? added
comment:2 follow-up: ↓ 3 Changed 10 years ago by manuq
Having a quick look for now:
The toggle works very well for all device icons with the exception of the network, which is not showing the palette here.
An issue that I see: tap on a device icon to make it's palette pop up, do the global gesture. Palette stays, should pop down.
comment:3 in reply to: ↑ 2 Changed 10 years ago by erikos
Replying to manuq:
Having a quick look for now:
The toggle works very well for all device icons with the exception of the network, which is not showing the palette here.
Ok, I fixed that in the latest toolkit patch. There was a do_clicked method in the toolbutton.
An issue that I see: tap on a device icon to make it's palette pop up, do the global gesture. Palette stays, should pop down.
A separate issue that has to do with Palette popdowns.
comment:4 Changed 10 years ago by manuq
Yes all device icons act as toggles now. And the cleanup patch is worth pushing too.
comment:5 Changed 10 years ago by erikos
- Keywords r+ olpc-test-pending added; r? removed
add toggle_palette option toolkit: http://git.sugarlabs.org/sugar-toolkit-gtk3/sugar-toolkit-gtk3/commit/1a8f89226b4f979000d80edc7123b7d22b23dc91
use toggle_palette option for ActivityButton: http://git.sugarlabs.org/sugar-toolkit-gtk3/sugar-toolkit-gtk3/commit/063e40d77da2f46108b5000e9bc48cfb7d167d32
Frame icons patch: http://git.sugarlabs.org/sugar/mainline/commit/da5e3e0a76a7a9222a4a36d251aeff7c8d227f5b
comment:6 Changed 10 years ago by erikos
- Resolution set to fixed
- Status changed from new to closed
Testcase:
Frame:
- check that the device icons (e.g. battery) popup/popdown on left click/touch
- check that the ActivityIcon in Chat or HelloWorld popup/popdown on left click/touch (no primary action)
- check that the HomeIcon in Browse does not popup Palette on left click/touch (has primary action)
comment:7 Changed 10 years ago by greenfeld
- Keywords olpc-test-passed added; olpc-test-pending removed
Fixed in 13.1.0 os9.
Shell patch that changes the device icons to set the toggle propperty available in the toolkit