Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#4065 closed defect (fixed)

Frame: device icons: icons should act as toggles on left mouse click ot tap, popup/popdown Palette

Reported by: erikos Owned by: erikos
Priority: High Milestone:
Component: Sugar Version: 0.97.x
Severity: Major Keywords: palettes, r+, olpc-test-passed
Cc: manuq Distribution/OS: OLPC
Bug Status: Assigned

Description


Attachments (6)

toggle_state.patch​ (10.8 KB) - added by erikos 11 years ago.
Shell patch that changes the device icons to set the toggle propperty available in the toolkit
toolkit_toggle_state.patch​ (3.9 KB) - added by erikos 11 years ago.
Adding a toggle-palette property to the invoker
0001-Add-toggle_palette-property-for-Palette-invoker-SL-4.patch​ (5.1 KB) - added by erikos 11 years ago.
Add toggle_palette property for Palette invoker
0001-ActivityButton-set-the-toggle_palette-option-to-True.patch​ (1010 bytes) - added by erikos 11 years ago.
ActivityButton: set the toggle_palette invoker property to true
0001-Frame-use-the-new-toggle_palette-invoker-property-SL.patch​ (11.7 KB) - added by erikos 11 years ago.
Frame: use the new toggle_palette invoker property
0001-Palettes-move-PRIMARY-and-SECONDARY-constant-to-the-.patch​ (1.9 KB) - added by erikos 11 years ago.
Palettes: move PRIMARY and SECONDARY constant to the base class

Download all attachments as: .zip

Change History (14)

Changed 11 years ago by erikos

Shell patch that changes the device icons to set the toggle propperty available in the toolkit

Changed 11 years ago by erikos

Adding a toggle-palette property to the invoker

comment:1 Changed 11 years ago by erikos

  • Cc manuq added
  • Keywords r? added

comment:2 follow-up: Changed 11 years ago by manuq

Having a quick look for now:

The toggle works very well for all device icons with the exception of the network, which is not showing the palette here.

An issue that I see: tap on a device icon to make it's palette pop up, do the global gesture. Palette stays, should pop down.

Changed 11 years ago by erikos

Add toggle_palette property for Palette invoker

Changed 11 years ago by erikos

ActivityButton: set the toggle_palette invoker property to true

Changed 11 years ago by erikos

Frame: use the new toggle_palette invoker property

comment:3 in reply to: ↑ 2 Changed 11 years ago by erikos

Replying to manuq:

Having a quick look for now:

The toggle works very well for all device icons with the exception of the network, which is not showing the palette here.

Ok, I fixed that in the latest toolkit patch. There was a do_clicked method in the toolbutton.

An issue that I see: tap on a device icon to make it's palette pop up, do the global gesture. Palette stays, should pop down.

A separate issue that has to do with Palette popdowns.

Changed 11 years ago by erikos

Palettes: move PRIMARY and SECONDARY constant to the base class

comment:4 Changed 11 years ago by manuq

Yes all device icons act as toggles now. And the cleanup patch is worth pushing too.

comment:6 Changed 11 years ago by erikos

  • Resolution set to fixed
  • Status changed from new to closed

Testcase:

Frame:

  • check that the device icons (e.g. battery) popup/popdown on left click/touch
  • check that the ActivityIcon in Chat or HelloWorld popup/popdown on left click/touch (no primary action)
  • check that the HomeIcon in Browse does not popup Palette on left click/touch (has primary action)

comment:7 Changed 11 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

Fixed in 13.1.0 os9.

comment:8 Changed 10 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.