Browse: autocomplete list occludes OSK

[manuq]

TestCase:

• start Browse with the laptop in ebook mode
• tap in the url entry and start typing with the on-screen keyboard

Autocomplete list should not occlude the OSK. Test after you have navigated many pages so the list shows the maximun number of matches.

[manuq]

Screen capture.

[manuq]

Autocomplete list with the patch applied.

[manuq]

For the row height, another approach can be have the url below the title in the autocomplete list.

[manuq]

Candidate patch.

[garycmartin]

Replying to manuq:

For the row height, another approach can be have the url below the title in the autocomplete list.

Yes, as per discussion irc the width of the history results is rather narrow these days due to Browse feature creep in the toolbar, reducing the URL input field width. See attached screen shot from an early shipping Sugar build. Putting the url below the title will much improve information visibility for each result and make the hit area larger for touch use. Having the history alternate light grey / dark grey can be used to separate each title/url pair from the next to make it clear they each pair belongs together (without needing to add extra space for a separator). The impact is that with the OSK open we can only show about 7 search history matches. A feature for a future cycle should be opened for allowing the history to be scrolled through all the matching results.

[erikos]

Shouldn't we theme the list Palette like? At least with a black border.

[garycmartin]

Replying to erikos:

Shouldn't we theme the list Palette like? At least with a black border.

Black background with a grey outline, white text and grey separators would make it palette like. But that seems a lot of work at this stage in the game, and the needed separators would consume more vertical space – so should perhaps hold off until we can add in scrolling the results?

[manuq]

Pushed as 9c120d63, and filled a ticket #4081 for next cycle to track the future improvements.

[manuq]

Reopening as we can improve this solution, as per Simon suggestions. First of, remove the gap that was introduced in the port to webkit. This is a regression. Later, see if the styling of the autocomplete list can be improved.

[manuq]

Remove gap.

[manuq]

Styling option 1, like the original gecko but with palette colors

[manuq]

Styling option 2, squaring the bottom corners of the entry to make the list the same width

[manuq]

Styling option 3, like v2 but with black text over white background.

[garycmartin]

An additional palette like search history mockup

[manuq]

Patch that gets closer to the mockup.

[manuq]

Patch similar than the previous, counter proposal.

[manuq]

Artwork patch to style the list like a palette.

[manuq]

Screengrab of 0002-Improve-styling-of-the-autocomplete-list-SL-4049-V1.patch

[manuq]

Screengrab of 0002-Improve-styling-of-the-autocomplete-list-SL-4049-V2.patch

[manuq]

I was close to the mockup, but found difficult to add the inner space at both sides of the entry. So I came to a counter proposal.

[manuq]

Adding margin to the text items.

[manuq]

Pushed Browse 990f4ddc - 5540c90c and artwork a5da6e4e . Let's use #4081 for further improvements.

[greenfeld]

The autocomplete list is safely above the OSK in portrait and landscape modes in OLPC 13.1.0 os8.

[dnarvaez]

Milestone 0.98 deleted