Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#4036 closed defect (fixed)

Activity title: clear entry

Reported by: erikos Owned by: humitos
Priority: High Milestone:
Component: Sugar Version: 0.97.x
Severity: Major Keywords: r+, olpc-test-passed
Cc: garycmartin, manuq Distribution/OS: OLPC
Bug Status: Assigned

Description

It is hard to set a complete new activity title at the moment, when you tap/click into the entry you have to erase each letter one by one, either using the OSK or the hardware keyboard.

on the table:

  • select all text when tap/click
  • have an 'x' icon like in other entries
  • tap+start typing will erase the existing one

tested in os6

Attachments (1)

0001-Auto-select-text-when-tap-click-on-title-entry-SL-40.patch (1.6 KB) - added by humitos 7 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 7 years ago by erikos

  • Cc garycmartin manuq added

comment:2 Changed 7 years ago by manuq

+1 to have an 'x' icon like in other entries.

comment:3 follow-up: Changed 7 years ago by garycmartin

Adding the 'x' makes more sense for search fields, as you frequently have clear the string. Empty is the default case you need to return to after any search, the 'x' also costs us some space in the widget. For Activity Titles, I'd rather 'select all text when first tap/click' so that typing can replace the whole string, with an additional tap/click to remove the selection and place the cursor somewhere for making a smaller edit to the Title.

comment:4 in reply to: ↑ 3 Changed 7 years ago by manuq

Replying to garycmartin:

Adding the 'x' makes more sense for search fields, as you frequently have clear the string. Empty is the default case you need to return to after any search, the 'x' also costs us some space in the widget. For Activity Titles, I'd rather 'select all text when first tap/click' so that typing can replace the whole string, with an additional tap/click to remove the selection and place the cursor somewhere for making a smaller edit to the Title.

Yes your points sound good to me.

comment:5 Changed 7 years ago by humitos

  • Owner changed from erikos to humitos
  • Status changed from new to accepted

comment:6 Changed 7 years ago by humitos

  • Component changed from sugar to sugar-toolkit-gtk3
  • Keywords r? added

I've just upload a patch for revision.

The idea is:

  • when the entry is tapped/clicked and it's not focused (initial tap/click), we select all the text and focus this entry and we do not propagate that event to other handlers.
  • when the entry is tapped/clicked and it IS focused (second/third... tap/click), we just propagate that event to other handlers. This allows the user to select text with the mouse, for example.

comment:7 Changed 7 years ago by erikos

  • Keywords r+ olpc-test-pending added; r? removed
  • Resolution set to fixed
  • Status changed from accepted to closed

Thanks, I like the patch and it does what it claims it does, pushed as 7b8fa5e406d8ff5c66f05f8ab3961317f3744794

comment:8 Changed 7 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

Whenever the activity title field receives focus via the mouse or touch the entire text in said field is highlighted in 13.1.0 os20/Sugar 0.98.2.

{This caused me to delete an entry's name in the journal once though by accident, and I didn't realize until later I had done that.}

comment:9 Changed 7 years ago by dnarvaez

  • Component changed from sugar-toolkit-gtk3 to Sugar

comment:10 Changed 6 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.