Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#4025 closed enhancement (fixed)

Improve circle/spiral layout of favourite view to improve touch target size/spacing

Reported by: garycmartin Owned by: manuq
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: Unspecified
Severity: Unspecified Keywords: r+, olpc-test-passed
Cc: manuq, dsd, walter Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

Improve the circle/spiral layout of favourite view to improve target size/spacing for touch users.

Change History (14)

comment:1 Changed 9 years ago by garycmartin

  • Cc manuq added

I wanted to get the attached patch tracked and available for testing just in case the current size of Home view icons is seen as a release blocker for XO-4 touch hardware.

Changed 9 years ago by garycmartin

comment:2 Changed 9 years ago by garycmartin

  • Keywords r? added

Changed 9 years ago by garycmartin

comment:3 Changed 9 years ago by dsd

  • Cc dsd added
  • Owner changed from garycmartin to manuq
  • Status changed from new to assigned

comment:4 Changed 9 years ago by dsd

  • Cc walter added

Walter, we are looking at landing this today. If you have time for a review or any comments, it would be much appreciated.

comment:5 Changed 9 years ago by walter

Visually, I think it is a bi improvement. Haven't had a chance to review the code yet.

comment:6 Changed 9 years ago by manuq

Great work Gary.

This patch switches from fixed intermadiate sizes (the removed _INTERMEDIATE_* constants) to dynamic intermadiate sizes. I think this is worth to mention in the commit message. Is in the follow up patch I'm attaching.

The new calculation in _calculate_radius_and_angle that involves a square root calculation is not trivial so I asked Gary for a comment in the code. In the follow up patch too.

The while loops try sizes 1 pixel smaller for each loop. This calls the square root calculation so I was worried about performance, but Gary said he tested and the layout time is not too much slower than
the previous.

This breaks the triangle and box layouts but by the way they are commented out in favoritesview.py .

Changed 9 years ago by manuq

Follow up patch.

comment:7 Changed 9 years ago by manuq

  • Keywords r+ added; r? removed

comment:8 Changed 9 years ago by erikos

  • Keywords olpc-test-pending added; 13.1.0 removed
  • Resolution set to fixed
  • Status changed from assigned to closed

comment:9 Changed 8 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

The Home View icons are a bit more spaced apart in the spiral view in OLPC 13.1.0 os8.

comment:10 Changed 8 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.