Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#4013 closed defect (fixed)

Touch: Get out of activity fullscreen mode

Reported by: erikos Owned by: erikos
Priority: High Milestone:
Component: Browse Version: 0.97.x
Severity: Major Keywords: r+, olpc-test-passed
Cc: humitos, manuq, gonzalo Distribution/OS: OLPC
Bug Status: Assigned

Description

Example:

  • open Browse
  • go to full-mode

---> [-><-] button goes away after a timeout

  • move the cursor

---> [-><-] button appears again and disappear after a timeout

  • click on the canvas

---> no [-><-] button appears

  • click on the top-top (the toolbar with the tabs)

---> [-><-] button appears

Tapping anywhere should bring back the button.

Attachments (2)

0001-Touch-Get-out-of-activity-fullscreen-mode-SL-4013.patch (2.2 KB) - added by humitos 7 years ago.
Maybe the code used in this patch can be modularized on the sugar3.graphics.window.Window class so it's not repeated
0001-Window-show-unfullscreen-button-on-button-and-touch-.patch (3.0 KB) - added by erikos 7 years ago.
Window: show unfullscreen button on button and touch events

Download all attachments as: .zip

Change History (16)

comment:1 Changed 7 years ago by erikos

  • Summary changed from Get out of fullscreen mode to Touch: Get out of activity fullscreen mode

comment:2 Changed 7 years ago by erikos

Read looks to behave quite well in this case.

comment:3 Changed 7 years ago by erikos

  • Cc humitos added
  • Component changed from sugar-toolkit-gtk3 to Browse

Imageviewer does work as well. So looks like we should fix Browse only for now.

Changed 7 years ago by humitos

Maybe the code used in this patch can be modularized on the sugar3.graphics.window.Window class so it's not repeated

comment:4 Changed 7 years ago by humitos

  • Keywords r? added

comment:5 Changed 7 years ago by manuq

  • Cc manuq added

comment:6 Changed 7 years ago by manuq

  • Resolution set to fixed
  • Status changed from new to closed

Terminal behaves well as well, so pushing humitos patch for Browse.

Thanks humitos, I just inverted the checks in the if conditional, first check if the activity is in fullscreen mode, so the callback returns right away if not.

Pushed c9975a7c .

comment:7 Changed 7 years ago by manuq

  • Keywords r+ 13.1.0 olpc-test-pending added; r? removed

comment:8 Changed 7 years ago by erikos

  • Resolution fixed deleted
  • Status changed from closed to reopened

I am not happy with the Browse patch:

  • I think we should add that to the toolkit so it is available to all the activities, we should not only track mouse events there but as well show the unfullscreen button on button presses and touch taps, button presses were not considered before as they often get along with a mouse movement - it is rare that you do a click without a touch movement, but they should be considered to complete the picture.
  • if you have to do things like "self._Windowunfullscreen_button_timeout_cb" often something is wrong with the approach, please check as well #1434 if there is not a better solution

Toolkit patch attached. Tested with Browse, Read and Imageviewer.

comment:9 follow-up: Changed 7 years ago by erikos

  • Cc gonzalo added

While checking, I think this code can go away in Read:

diff --git a/readactivity.py b/readactivity.py
index eaedf81..5ff413a 100644
--- a/readactivity.py
+++ b/readactivity.py
@@ -340,12 +340,6 @@ class ReadActivity(activity.Activity):
         #else:
         #    self._load_document('file:///home/smcv/tmp/test.pdf')
 
-    def fullscreen(self):
-        activity.Activity.fullscreen(self)
-
-    def unfullscreen(self):
-        activity.Activity.unfullscreen(self)
-
     def _create_back_button(self):
         back = ToolButton('go-previous-paired')
         back.set_tooltip(_('Back'))

comment:10 Changed 7 years ago by erikos

  • Keywords r? added; r+ olpc-test-pending removed

Changed 7 years ago by erikos

Window: show unfullscreen button on button and touch events

comment:11 Changed 7 years ago by erikos

  • Keywords r+ olpc-test-pending added; r? 13.1.0 removed
  • Resolution set to fixed
  • Status changed from reopened to closed

comment:12 in reply to: ↑ 9 Changed 7 years ago by godiard

Replying to erikos:

You are right, removed. (Before Read used the topbar in fullscreen mode, but is not used anymore)

While checking, I think this code can go away in Read:

diff --git a/readactivity.py b/readactivity.py
index eaedf81..5ff413a 100644
--- a/readactivity.py
+++ b/readactivity.py
@@ -340,12 +340,6 @@ class ReadActivity(activity.Activity):
         #else:
         #    self._load_document('file:///home/smcv/tmp/test.pdf')
 
-    def fullscreen(self):
-        activity.Activity.fullscreen(self)
-
-    def unfullscreen(self):
-        activity.Activity.unfullscreen(self)
-
     def _create_back_button(self):
         back = ToolButton('go-previous-paired')
         back.set_tooltip(_('Back'))

comment:13 Changed 7 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

Touching the touchscreen or moving the mouse cursor causes the fullscreen exiting icon to appear for a few seconds in Browse-145/OLPC 13.1.0 os9.

comment:14 Changed 6 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.