Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#3993 closed defect (fixed)

Reveal Frame in ebook mode

Reported by: erikos Owned by: erikos
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: 0.97.x
Severity: Major Keywords: r+, olpc-test-passed
Cc: Distribution/OS: OLPC
Bug Status: Resolved

Description

The gesture code should handle the new proportions in ebook mode fine.

seen is os5

Attachments (1)

0001-Reveal-frame-in-ebook-mode-SL-3993.patch (1.4 KB) - added by erikos 9 years ago.
Patch for the shell to take GdkScreen-size-changed into account

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by erikos

Ok, we can listen on GdkScreen-size-changed and remove/add the controllers again depending on the new w/h. Carlos will add the remove API to sugar-gesture-grabber and then we can adopt the Frame code to it.

Changed 9 years ago by erikos

Patch for the shell to take GdkScreen-size-changed into account

comment:2 Changed 9 years ago by erikos

  • Keywords r? added

Global-gesture-remove-API has landed in toolkit-gtk3 http://git.sugarlabs.org/sugar-toolkit-gtk3/sugar-toolkit-gtk3/commit/c546aaaf7cab3a912c5245e024356a8d789feaa2

Attached is the patch for the shell.

comment:3 Changed 9 years ago by manuq

Great, after compiling the latest sugar-toolkit-gtk3 I applied your patch for the shell and now the gesture can be actioned from the bottom side and right side, relative to screen orientation, when the screen is in portrait/ebook layout.

comment:4 Changed 9 years ago by erikos

  • Bug Status changed from Assigned to Resolved
  • Keywords r+ olpc-test-pending added; r? removed
  • Resolution set to fixed
  • Status changed from new to closed

comment:5 Changed 8 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

Rotating a XO-1.75 with touchscreen (since the XO-4 fb driver cannot be rotated via the rotate key) has the frame reveal gesture rotate with the screen in OLPC 13.1.0 os8.

comment:6 Changed 8 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.