#3988 closed defect (fixed)
Journal: entry is focused when using the zoom level buttons or the Journal key
| Reported by: | erikos | Owned by: | erikos |
|---|---|---|---|
| Priority: | Unspecified by Maintainer | Milestone: | |
| Component: | Sugar | Version: | 0.97.x |
| Severity: | Major | Keywords: | r+, olpc-test-passed |
| Cc: | manuq | Distribution/OS: | OLPC |
| Bug Status: | Assigned |
Description
The entry should not be autofocused.
Tested in os5, sugar 0.97.6.
Attachments (1)
Change History (7)
Changed 11 years ago by erikos
comment:1 Changed 11 years ago by erikos
- Keywords r? added
- Severity changed from Unspecified to Major
comment:2 follow-up: ↓ 3 Changed 11 years ago by manuq
Good finding erikos.
For the Journal icon in Home View I'm +1. But for the Journal key in the keyboard, it has a magnifying glass icon, I think in this case it should focus the entry. If you agree I can provide a patch, otherwise please go and push.
comment:3 in reply to: ↑ 2 Changed 11 years ago by garycmartin
Replying to manuq:
Good finding erikos.
For the Journal icon in Home View I'm +1. But for the Journal key in the keyboard, it has a magnifying glass icon, I think in this case it should focus the entry. If you agree I can provide a patch, otherwise please go and push.
Hmmm, it's a borderline case, but I do think of that physical key as a switch to Journal key, not a search key. The hardware keyboards always had the wrong icon printed on it (I think Walter even hinted as much once) ;) It would also introduce an edge case variation in behaviour, if you have Journal set on a details view, and later press the search physical key you would arrive back at the Journal on the main view. We should either have this 'back to main view' behaviour for all cases of switching to the Journal, or none, not just one case. Something to discuss for another cycle.
-1
comment:4 Changed 11 years ago by erikos
- Keywords r+ olpc-test-pending added; r? removed
- Resolution set to fixed
- Status changed from new to closed
Pushed as http://git.sugarlabs.org/sugar/mainline/commit/4baef0b242305999172e898b67987b646cdbf085
Thanks for the review ad Gary for commenting.
comment:5 Changed 11 years ago by greenfeld
- Keywords olpc-test-passed added; olpc-test-pending removed
The journal search does not take focus unless it was previously focused in 13.1.0 os7.
Journal key: do only reveal Journal without focusing the search entry