Buttons: theme 'active' state correctly

[erikos]

• go to the Journal, try to erase an entry

• in the alert click the 'cancel' button

---> in the 'active' (pressed) state the button is all white

[erikos]

Gary suggests to do: "White background with black text, the icon should be black as well."

Old builds do: "white fill, with black text, and a grey stroke for the icon"

[manuq]

Patch that fixes the color of the label inside buttons. I have to investigate how to change the icon color.

[manuq]

The patch attached here went in, commit 9cfc22cb .

What's pending is change the icon color.

[manuq]

The proper way to do the icon switch colors in the active state is making a theme engine. This is how the gtk2 engine was doing for changing the color of insensitive icons:

• In toolkit icon.py the style.render_icon is called ​here, and that is handled by the gtk2 theme ​here, which calls ​this function that ​change the svg.

So we should create a gtk3 engine and reimplement ​gtk_render_icon or look for a workaround.

[manuq]

Moved to next milestone as we are not going to add an engine now.

[manuq]

Reference links:

• ​gtk_icon_info_load_symbolic() documentation on loading symbolic (SVG) icons

• ​freedesktop.org symbolic icons spec