Opened 7 years ago

Last modified 5 years ago

#3974 new defect

Buttons: theme 'active' state correctly

Reported by: erikos Owned by: erikos
Priority: Normal Milestone: Unspecified
Component: Sugar Version: 0.97.x
Severity: Critical Keywords:
Cc: Distribution/OS: Fedora
Bug Status: New

Description

  • go to the Journal, try to erase an entry
  • in the alert click the 'cancel' button

---> in the 'active' (pressed) state the button is all white

Attachments (1)

0002-Don-t-set-color-for-GtkLabel-do-it-in-containers-ins.patch (2.3 KB) - added by manuq 7 years ago.
Patch that fixes the color of the label inside buttons. I have to investigate how to change the icon color.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 7 years ago by erikos

Gary suggests to do: "White background with black text, the icon should be black as well."

Old builds do: "white fill, with black text, and a grey stroke for the icon"

Changed 7 years ago by manuq

Patch that fixes the color of the label inside buttons. I have to investigate how to change the icon color.

comment:2 Changed 7 years ago by manuq

  • Priority changed from Unspecified by Maintainer to High

comment:3 Changed 7 years ago by manuq

The patch attached here went in, commit 9cfc22cb .

What's pending is change the icon color.

comment:4 Changed 7 years ago by manuq

The proper way to do the icon switch colors in the active state is making a theme engine. This is how the gtk2 engine was doing for changing the color of insensitive icons:

So we should create a gtk3 engine and reimplement gtk_render_icon or look for a workaround.

comment:5 Changed 7 years ago by manuq

  • Milestone changed from 0.98 to 1.0

Moved to next milestone as we are not going to add an engine now.

comment:6 Changed 7 years ago by manuq

comment:7 Changed 6 years ago by dnarvaez

  • Component changed from sugar-artwork to Sugar
  • Owner changed from manuq to erikos

comment:8 Changed 6 years ago by dnarvaez

  • Milestone changed from 1.0 to Unspecified

comment:9 Changed 6 years ago by dnarvaez

  • Bug Status changed from Assigned to Unconfirmed

comment:10 Changed 6 years ago by dnarvaez

  • Bug Status changed from Unconfirmed to New

comment:11 Changed 5 years ago by manuq

  • Priority changed from High to Normal
Note: See TracTickets for help on using tickets.