password dialog: 'Ok' button does not show if a passphrase entered has the correct length

[erikos]

• connect to a secure AP

• enter pw

---> The 'Ok' button should signal if the passphrase hasthe correct length

(could be an artwork issue as well)

[humitos]

Where did you see this behaviour?

I tried to test this in my sugar-build with f17 and I wasn't able to connect to an encrypted ap. The password dialogue is not shown at all.

I tried to connect to another open AP and I couldn't reach it as well.

This is what I get in the shell.log each time that I try to connect to one ap.

1349058824.311032 ERROR root: Failed to add and activate connection:
org.freedesktop.NetworkManager.Settings.NotPrivileged: Insufficient privileges.

I don't know why but I can connect to my own ap. It's open like another one that I tried and I couldn't reach from sugar but I could reach from GNOME.

[erikos]

Use os4. In sugar-build it will use your systems settings.

[erikos]

We actually do change the 'Ok' button when the passphrase has the correct length but as we do display the ​GTK-STOCK-OK icon I did not see that right away.

The Gtk.STOCK_CANCEL stock icon is mapped to the Sugar one, the Gtk.STOCK_OK icon is not. I could not figure out why, or why this has been working before.

Let's use ​gtk-dialog-add-action-widget and add buttons that use the Sugar Icons.

[erikos]

AP password dialog: theme the ok button correctly

[erikos]

theme the GtkDialog

[erikos]

test app

[erikos]

Two small feedback items from Gary:

• the title could be bg=black, text=white as well or remove it (maybe with set_decorations on the gdk window)

• the text in the 'ok' button could be grey when inactive

But those are further improvements if, the current bits can already go in.

[manuq]

Great,

for the OK icon issue, the correct name for GTK_STOCK_OK is "gtk-ok":

​http://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOCK-OK:CAPS

I will give a try.

[manuq]

So please proceed with this fix. I investigated the stock issue but no luck finding why the sugar dialog-cancel is replacing the gtk default icon but dialog-ok (or gtk-ok) doesn't.

[erikos]

Pushed the Sugar patch: ​http://git.sugarlabs.org/sugar/mainline/commit/e731544ff72377bdfb64212e9ab048fe101113b8 and the artwork one ​http://git.sugarlabs.org/sugar-artwork/mainline/commit/2258337c47c5d5590722a9254db4f31d1010619b

For testing, check that the dialogue looks like this:

​http://bugs.sugarlabs.org/attachment/ticket/3971/pw-dialog.png

​http://bugs.sugarlabs.org/attachment/ticket/3971/pw-dialog-ok-active.png

[erikos]

#4010 tracks the stock-icon issue further.

[greenfeld]

We theme the password dialog with a subtle password length hint in OLPC 13.1.0 os7.

[dnarvaez]

Milestone 0.98 deleted