Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#3971 closed defect (fixed)

password dialog: 'Ok' button does not show if a passphrase entered has the correct length

Reported by: erikos Owned by: erikos
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: 0.97.x
Severity: Minor Keywords: r+, olpc-test-passed
Cc: manuq, humitos Distribution/OS: OLPC
Bug Status: Assigned

Description

  • connect to a secure AP
  • enter pw

---> The 'Ok' button should signal if the passphrase hasthe correct length

(could be an artwork issue as well)

Attachments (5)

0001-AP-password-dialog-theme-the-ok-button-correctly-SL-.patch (1.6 KB) - added by erikos 10 years ago.
AP password dialog: theme the ok button correctly
0001-GtkDialog-theme-dialog-with-a-black-bg-and-white-tex.patch (822 bytes) - added by erikos 10 years ago.
theme the GtkDialog
testdialog.py (1.2 KB) - added by erikos 10 years ago.
test app
pw-dialog.png (13.4 KB) - added by erikos 10 years ago.
pw-dialog-ok-active.png (14.2 KB) - added by erikos 10 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 10 years ago by humitos

  • Cc humitos added

Where did you see this behaviour?

I tried to test this in my sugar-build with f17 and I wasn't able to connect to an encrypted ap. The password dialogue is not shown at all.

I tried to connect to another open AP and I couldn't reach it as well.

This is what I get in the shell.log each time that I try to connect to one ap.

1349058824.311032 ERROR root: Failed to add and activate connection:
org.freedesktop.NetworkManager.Settings.NotPrivileged: Insufficient privileges.

I don't know why but I can connect to my own ap. It's open like another one that I tried and I couldn't reach from sugar but I could reach from GNOME.

comment:2 Changed 10 years ago by erikos

Use os4. In sugar-build it will use your systems settings.

comment:3 Changed 10 years ago by erikos

  • Cc manuq added
  • Keywords r? added

We actually do change the 'Ok' button when the passphrase has the correct length but as we do display the GTK-STOCK-OK icon I did not see that right away.

The Gtk.STOCK_CANCEL stock icon is mapped to the Sugar one, the Gtk.STOCK_OK icon is not. I could not figure out why, or why this has been working before.

Let's use gtk-dialog-add-action-widget and add buttons that use the Sugar Icons.

Changed 10 years ago by erikos

AP password dialog: theme the ok button correctly

Changed 10 years ago by erikos

theme the GtkDialog

Changed 10 years ago by erikos

test app

Changed 10 years ago by erikos

Changed 10 years ago by erikos

comment:4 Changed 10 years ago by erikos

Two small feedback items from Gary:

  • the title could be bg=black, text=white as well or remove it (maybe with set_decorations on the gdk window)
  • the text in the 'ok' button could be grey when inactive

But those are further improvements if, the current bits can already go in.

comment:5 Changed 10 years ago by manuq

Great,

for the OK icon issue, the correct name for GTK_STOCK_OK is "gtk-ok":

http://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOCK-OK:CAPS

I will give a try.

comment:6 Changed 10 years ago by manuq

So please proceed with this fix. I investigated the stock issue but no luck finding why the sugar dialog-cancel is replacing the gtk default icon but dialog-ok (or gtk-ok) doesn't.

comment:8 Changed 10 years ago by erikos

#4010 tracks the stock-icon issue further.

comment:9 Changed 10 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

We theme the password dialog with a subtle password length hint in OLPC 13.1.0 os7.

comment:10 Changed 10 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.