Opened 11 years ago

Closed 9 years ago

#3962 closed defect (fixed)

GTK3 treeview root item styled with rounded corners

Reported by: garycmartin Owned by: manuq
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Sugar Version: 0.97.x
Severity: Unspecified Keywords: 13.1.0
Cc: manuq Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description (last modified by godiard)

The new GTK3 treeview root item is getting styled with rounded corners, the original version does not have the rounded corners (seen in Log and and the index in Read). See attached screen shot. This issue is only present on F20 (Gtk 3.10.9)

Attachments (5)

gtk_treeview_lists_have_round_style_for_root_item.png​ (63.1 KB) - added by garycmartin 11 years ago.
treeview_header.png​ (14.9 KB) - added by manuq 11 years ago.
Header with the patch applied.
treeview_header-selected.png​ (15.0 KB) - added by manuq 11 years ago.
Header selected, with the patch applied.
treeview_header-selected-new.png​ (11.6 KB) - added by manuq 11 years ago.
Header selected with the new patch.
0001-Set-background-color-to-GtkTreeView-SL-3962.patch​ (1.1 KB) - added by manuq 11 years ago.
Candidate patch.

Download all attachments as: .zip

Change History (14)

Changed 11 years ago by garycmartin

comment:1 Changed 11 years ago by manuq

  • Owner changed from erikos to manuq
  • Status changed from new to assigned

Thanks for the report Gary. Please when possible assign theme issues to me directly, adding my nickname in the author field, so we don't bother erikos too much :)

Changed 11 years ago by manuq

Header with the patch applied.

Changed 11 years ago by manuq

Header selected, with the patch applied.

comment:2 Changed 11 years ago by manuq

Adding this to the CSS makes the header square again. Note the change in the header selected. Previously we had round corners for the selected state, like a button, and the same background color in the cage that contained it.

column-header .button {
    border-radius: 0px;
}

Changed 11 years ago by manuq

Header selected with the new patch.

comment:3 Changed 11 years ago by manuq

Got it, this restored the selected state too:

GtkTreeView {
    background-color: @button_grey;
}

Changed 11 years ago by manuq

Candidate patch.

comment:4 Changed 11 years ago by manuq

  • Resolution set to fixed
  • Status changed from assigned to closed

Pushed 49f89431 .

comment:5 Changed 10 years ago by dnarvaez

  • Component changed from sugar-artwork to Sugar

comment:6 Changed 10 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

comment:7 Changed 9 years ago by godiard

  • Milestone set to Unspecified
  • Resolution fixed deleted
  • Status changed from closed to reopened

This issue regressed on F20 (in F18 is ok)

Something changed on Gtk land.

I have tried add again "column-header .button" and "column-header.button",
as Adwaita is using without success.

Adwaite is now a binary theme, a useful resource to research it is ​http://worldofgnome.org/how-to-hack-gnomes-adwaita-gtk-theme/

comment:8 Changed 9 years ago by godiard

  • Description modified (diff)

comment:9 Changed 9 years ago by godiard

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed by ​https://github.com/sugarlabs/sugar-artwork/commit/ae13635ac43f35983468a6cdbf4f7af4e212def0

Note: See TracTickets for help on using tickets.