#3933 closed defect (fixed)
Dark background behind embedded media player in Browse
Reported by: | greenfeld | Owned by: | manuq |
---|---|---|---|
Priority: | Low | Milestone: | |
Component: | Browse | Version: | Unspecified |
Severity: | Unspecified | Keywords: | regression, olpc-test-pending |
Cc: | humitos | Distribution/OS: | OLPC |
Bug Status: | Unconfirmed |
Description
There is a dark background behind the embedded media player in Browse in OLPC 13.1.0 os2.
While many media players like dark backgrounds, the embedded player shows progress information with black text, making it hard to read.
Seen with the OLPC library samples included with the build.
Attachments (4)
Change History (16)
comment:1 Changed 11 years ago by dsd
- Milestone changed from Unspecified by Release Team to 0.98
- Owner changed from erikos to dsd
- Status changed from new to assigned
comment:2 Changed 11 years ago by godiard
- Priority changed from Unspecified by Maintainer to Low
comment:3 Changed 11 years ago by humitos
- Cc humitos added
Changed 11 years ago by humitos
Changed 11 years ago by humitos
comment:4 follow-up: ↓ 5 Changed 11 years ago by dsd
Now check 13.1.0 and you will see what this bug report is about.
comment:5 in reply to: ↑ 4 Changed 11 years ago by humitos
Replying to dsd:
Now check 13.1.0 and you will see what this bug report is about.
Yes, yes. I've already checked that and I agree with the bug report that greenfeld filled here.
The thing is: how do we want to fix it?
- show the visualization as it was in the Gecko version or
- make the background as light as it is in 12.1.0
comment:6 Changed 11 years ago by dsd
Making it use the totem plugin for playback is an option that seems unlikely to happen, so fixing the appearance of the internal ogg player that is already appearing seems like the way to go.
comment:7 Changed 11 years ago by humitos
I tried what manuq told me about the sugar-artwork and the entry BrowseTabPage { background-color: @black; } but it didn't work. I changed it to @white
I ran Browse v140 on 13.1.0 and I noticed that the difference is not the webpage / browse background but the plugin background (check the differences in the screenshots)
comment:8 Changed 11 years ago by humitos
- Keywords regression added
comment:9 Changed 10 years ago by manuq
The patch at #4465 also fixes this:
http://bugs.sugarlabs.org/attachment/ticket/4465/sugarized_media_player.py
comment:10 Changed 10 years ago by manuq
- Owner changed from dsd to manuq
comment:11 Changed 10 years ago by manuq
- Keywords olpc-test-pending added
- Resolution set to fixed
- Status changed from assigned to closed
Pushed 4bc02188 .
How it should work?
I've just test the Gecko version of Browse (129.1) with an .ogg file and it show a visualization plugin with a progress bar at the bottom, a pause button and a volume slider.
The version included in 12.1.0 build 21 (140) shows a dark background as well, but not too dark to make difficult to see the progress bar.
What do we want?