Journal palette is not updated when I stay in the same column

[manuq]

Steps to reproduce:

In the Journal reveal the Palette of an entry (activity icon). Now move the cursor over another activity icon. The Palette from A does not go away and no Palette of B is revealed.

[manuq]

Same happens with activity icons in home list view, and doesn't happen with icons in the favourites view, so is an issue with cellrenderer icons.

[erikos]

Actually the issue is deeper than that. If you hover over an activity icon of a Journal entry, the Palette appears, if you hover out, the Palette does not go away. This is because the Palette code checks whether the cursor is still over the treeview rather than over the icon only.

[erikos]

CellRendererInvoker: use the cell renderer allocation not the TreeView one

[erikos]

The above patch does fix part of the issue: at the moment the Activity Palette of a Journal entry does only go away when you click outside it (as this Palette is based on a Gtk.Menu this is the typical GTK.Menu behaviour). With this Patch the Palette does also go away when you hover over the icon (Palette is revealed) and you go over the Palette with the mouse and then leave the Palette. The case where if you leave the invoker (icon) without ever entering the Palette is not yet handled.

[erikos]

GtkMenu: use point_in_cell_renderer for CellRendereInvoker to check if a point is in

[erikos]

The latest patch does actually solve the complete case. The Palette is popped down when the mouse pointer moves out of the Invoker (as well when it has not been entered the Palette once).

[erikos]

There is a small edge case with the above: when you move the mouse out of the icon the Palette was invoked of and stay in the same treeview column the Palette does not go away. Could be that this is the case because we only take x into account in _point_in_cell_renderer ​http://git.sugarlabs.org/sugar-toolkit-gtk3/sugar-toolkit-gtk3/blobs/master/src/sugar3/graphics/palettewindow.py#line1322.

[erikos]

Journal TreeView: make sure Palette is hidden when resuming Activity

[erikos]

The patch above is for the issue originally described in the ticket: when you resume an activity in the Journal by tapping on the icon the Palette of that icon did not popdown.

[manuq]

Replying to erikos:

There is a small edge case with the above: when you move the mouse out of the icon the Palette was invoked of and stay in the same treeview column the Palette does not go away. Could be that this is the case because we only take x into account in _point_in_cell_renderer ​http://git.sugarlabs.org/sugar-toolkit-gtk3/sugar-toolkit-gtk3/blobs/master/src/sugar3/graphics/palettewindow.py#line1322.

For this case we can watch the path returned by tree_view.get_path_at_pos which is being called in point_in_cell_renderer. If path changes, we are in another row.

[erikos]

The ticket originally described here, see #4129 which I just closed.

Let's adjust the title here to track the edge case discovered here.

[tch]

Still present in 0.107.0.