Opened 11 years ago
Last modified 9 years ago
#3833 assigned defect
Palettes on the bottom of screen don't appear after rotation to portrait mode
Reported by: | godiard | Owned by: | manuq |
---|---|---|---|
Priority: | High | Milestone: | Unspecified |
Component: | Sugar | Version: | 0.97.x |
Severity: | Major | Keywords: | r+ |
Cc: | erikos | Distribution/OS: | OLPC |
Bug Status: | Unconfirmed |
Description (last modified by walter)
The actual code caches the screen width and height, then after rotate the screen, calculate palette position fails, because the palettes are out of the cached positions.
A tentative patch is here [1], but show a difference in behavior, the pallete width does not take in account the frame width.
[1] http://lists.sugarlabs.org/archive/sugar-devel/2012-August/039240.html
This is an issue in both the Journal and on the Frame.
Attachments (4)
Change History (22)
comment:1 Changed 11 years ago by erikos
- Bug Status changed from Unconfirmed to Assigned
- Milestone changed from Unspecified by Release Team to 0.98
- Severity changed from Unspecified to Major
- Version changed from Unspecified to 0.97.x
comment:2 Changed 11 years ago by erikos
- Distribution/OS changed from Unspecified to OLPC
Testcase to show regression with current patch:
- apply patch
- reveal Frame and reveal the Speaker or Speech device Palette
comment:3 Changed 11 years ago by godiard
- Keywords r? added
comment:4 Changed 11 years ago by godiard
- Priority changed from Unspecified by Maintainer to Normal
comment:5 Changed 11 years ago by manuq
- Owner changed from erikos to manuq
- Status changed from new to assigned
Changed 11 years ago by manuq
comment:7 Changed 11 years ago by manuq
The palette position relative to the button is not right after screen rotation. But at least it is displayed. So the patch should be improved.
comment:8 Changed 11 years ago by erikos
- Keywords r+ added; r? removed
- Milestone changed from 0.98 to 1.0
We land it once we branched off, as it is not a regression. Hiding the Palette is not too bad when the screen is rotated.
comment:9 Changed 11 years ago by godiard
Mhhhhh.....
comment:10 Changed 11 years ago by manuq
Also filed as #4419 - we gained two more patches there:
http://bugs.sugarlabs.org/ticket/4419#comment:3
http://bugs.sugarlabs.org/ticket/4419#comment:4
comment:11 follow-up: ↓ 12 Changed 11 years ago by manuq
I see the issue I spotted at comment 7 in all three solutions, which I describe in more detail here: after rotating the screen with the patches applied, the palettes can be placed over the toolbar, obscuring the other buttons. I attach a screen grab. In the case of the patch that removes size cache, this happens also before rotating the screen.
Changed 11 years ago by manuq
comment:12 in reply to: ↑ 11 Changed 11 years ago by manuq
Replying to manuq:
I see the issue I spotted at comment 7 in all three solutions, which I describe in more detail here: after rotating the screen with the patches applied, the palettes can be placed over the toolbar, obscuring the other buttons. I attach a screen grab. In the case of the patch that removes size cache, this happens also before rotating the screen.
Forgot to say I see this issue only in the network and volume tray buttons.
comment:13 Changed 11 years ago by ajay_garg
Fully resolved patch at ::
http://lists.sugarlabs.org/archive/sugar-devel/2013-March/041978.html
comment:14 Changed 10 years ago by dnarvaez
- Component changed from sugar-toolkit to Sugar
comment:15 Changed 10 years ago by dnarvaez
- Milestone changed from 1.0 to Unspecified
comment:16 Changed 10 years ago by dnarvaez
- Bug Status changed from Assigned to Unconfirmed
comment:17 Changed 9 years ago by godiard
- Priority changed from Normal to High
comment:18 Changed 9 years ago by walter
- Description modified (diff)
- Summary changed from sugar-toolkit: Palette in the bottom of screen don't appear with rotated screen to Palettes on the bottom of screen don't appear after rotation to portrait mode
Testcase:
---> the palette will not be displayed, and errors appear in the log