Opened 7 years ago

Last modified 5 years ago

#3833 assigned defect

Palettes on the bottom of screen don't appear after rotation to portrait mode

Reported by: godiard Owned by: manuq
Priority: High Milestone: Unspecified
Component: Sugar Version: 0.97.x
Severity: Major Keywords: r+
Cc: erikos Distribution/OS: OLPC
Bug Status: Unconfirmed

Description (last modified by walter)

The actual code caches the screen width and height, then after rotate the screen, calculate palette position fails, because the palettes are out of the cached positions.
A tentative patch is here [1], but show a difference in behavior, the pallete width does not take in account the frame width.

[1] http://lists.sugarlabs.org/archive/sugar-devel/2012-August/039240.html

This is an issue in both the Journal and on the Frame.

Attachments (4)

0001-Palette-update-position-when-the-screen-size-changes.patch (2.3 KB) - added by manuq 7 years ago.
0001-Palette-update-position-when-the-screen-size-changes.2.patch (2.1 KB) - added by manuq 7 years ago.
New version that fixes the issue of the previous one.
Screenshot of _Journal_.png (80.3 KB) - added by manuq 7 years ago.
sc.png (82.4 KB) - added by manuq 6 years ago.
Screenshot having applied patch in comment 13

Download all attachments as: .zip

Change History (22)

comment:1 Changed 7 years ago by erikos

  • Bug Status changed from Unconfirmed to Assigned
  • Milestone changed from Unspecified by Release Team to 0.98
  • Severity changed from Unspecified to Major
  • Version changed from Unspecified to 0.97.x

Testcase:

  • use an XO
  • go to the journal
  • rotate the screen
  • try to access devices palettes

---> the palette will not be displayed, and errors appear in the log

comment:2 Changed 7 years ago by erikos

  • Distribution/OS changed from Unspecified to OLPC

Testcase to show regression with current patch:

  • apply patch
  • reveal Frame and reveal the Speaker or Speech device Palette

comment:3 Changed 7 years ago by godiard

  • Keywords r? added

comment:4 Changed 7 years ago by godiard

  • Priority changed from Unspecified by Maintainer to Normal

comment:5 Changed 7 years ago by manuq

  • Owner changed from erikos to manuq
  • Status changed from new to assigned

comment:6 Changed 7 years ago by manuq

  • Cc erikos added

The attached patch seems to fix it.

comment:7 Changed 7 years ago by manuq

The palette position relative to the button is not right after screen rotation. But at least it is displayed. So the patch should be improved.

Changed 7 years ago by manuq

New version that fixes the issue of the previous one.

comment:8 Changed 7 years ago by erikos

  • Keywords r+ added; r? removed
  • Milestone changed from 0.98 to 1.0

We land it once we branched off, as it is not a regression. Hiding the Palette is not too bad when the screen is rotated.

comment:9 Changed 7 years ago by godiard

Mhhhhh.....

comment:11 follow-up: Changed 7 years ago by manuq

I see the issue I spotted at comment 7 in all three solutions, which I describe in more detail here: after rotating the screen with the patches applied, the palettes can be placed over the toolbar, obscuring the other buttons. I attach a screen grab. In the case of the patch that removes size cache, this happens also before rotating the screen.

Changed 7 years ago by manuq

comment:12 in reply to: ↑ 11 Changed 7 years ago by manuq

Replying to manuq:

I see the issue I spotted at comment 7 in all three solutions, which I describe in more detail here: after rotating the screen with the patches applied, the palettes can be placed over the toolbar, obscuring the other buttons. I attach a screen grab. In the case of the patch that removes size cache, this happens also before rotating the screen.

Forgot to say I see this issue only in the network and volume tray buttons.

Changed 6 years ago by manuq

Screenshot having applied patch in comment 13

comment:14 Changed 6 years ago by dnarvaez

  • Component changed from sugar-toolkit to Sugar

comment:15 Changed 6 years ago by dnarvaez

  • Milestone changed from 1.0 to Unspecified

comment:16 Changed 6 years ago by dnarvaez

  • Bug Status changed from Assigned to Unconfirmed

comment:17 Changed 5 years ago by godiard

  • Priority changed from Normal to High

comment:18 Changed 5 years ago by walter

  • Description modified (diff)
  • Summary changed from sugar-toolkit: Palette in the bottom of screen don't appear with rotated screen to Palettes on the bottom of screen don't appear after rotation to portrait mode
Note: See TracTickets for help on using tickets.