Clipboard drag&drop: error when dragging an icon to the clipboard

[erikos]

Steps to reproduce (you need to apply #3811 and #3818 first):

• open the Browse activity

• drag an image to the clipboard

---> the notification pulsing icon should be of the same type as the clipboard icon

1345538574.421700 DEBUG root: ClipboardTray: adding type 'text/uri-list'
1345538574.421790 DEBUG root: Clipboard.add_object_format
Traceback (most recent call last):
  File "/home/erikos/sugar-build/install/lib/python2.7/site-packages/jarabe/frame/clipboardtray.py", line 210, in drag_data_received_cb
    self._add_selection(object_id, selection)
  File "/home/erikos/sugar-build/install/lib/python2.7/site-packages/jarabe/frame/clipboardtray.py", line 96, in _add_selection
    on_disk=True)
  File "/home/erikos/sugar-build/install/lib/python2.7/site-packages/jarabe/frame/clipboard.py", line 92, in add_object_format
    new_uri = self._copy_file(data)
  File "/home/erikos/sugar-build/install/lib/python2.7/site-packages/jarabe/frame/clipboard.py", line 166, in _copy_file
    f_, new_file_path = tempfile.mkstemp(ext, root)
  File "/usr/lib/python2.7/tempfile.py", line 300, in mkstemp
    return _mkstemp_inner(dir, prefix, suffix, flags)
  File "/usr/lib/python2.7/tempfile.py", line 235, in _mkstemp_inner
    fd = _os.open(file, flags, 0600)
TypeError: must be encoded string without NULL bytes, not str
1345538574.424115 DEBUG root: ClipboardTray: got data for target '_NETSCAPE_URL'
1345538574.424240 DEBUG root: ClipboardTray: adding type '_NETSCAPE_URL'
1345538574.424326 DEBUG root: Clipboard.add_object_format

[manuq]

This seems to be an issue in WebKitGTK+, as the last guessed MIME in the repeated calls to the toolkit mime.choose_most_significant(mime_types) is "text/html".

[godiard]

I think this is related to #3903 and is a regression too.

[godiard]

With the rpms needed to solve #4307, we get the following error:

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/jarabe/frame/clipboardtray.py", line 134, in drag_motion_cb
    if self._internal_drag(context):
  File "/usr/lib/python2.7/site-packages/jarabe/frame/clipboardtray.py", line 187, in _internal_drag
    source_widget = context.get_source_widget()
AttributeError: 'gtk.gdk.X11DragContext' object has no attribute 'get_source_widget'

[manuq]

API fixes, unfinished patch, still some work to do

[manuq]

Patch. Still one thing pending, see FIXME.

[manuq]

I still need to research why the data comes with a 'x00' character at the end. Could be upstream bug, or an encoding issue.

[manuq]

Update: use get_uris() instead of splitting get_data()

[manuq]

Pushed to github master as 0aca8e59 after Daniel Narvaez review.

[dnarvaez]

Milestone 0.98 deleted