Clipboard, drag&drop: notification icon is 'application-octet'

[erikos]

When you drag&drop text or an image to the clipboard the notification icon will not be the 'application-octet' and not the corresponding one to the clipboard data. The icon of the clipboard item is the correct one.

Steps to reproduce (you need to apply #3811 first):

• open the Log activity

• select some text

• drag it to the clipboard

---> the notification pulsing icon should be of the same type as the clipboard icon

• open the Browse activity

• drag an image to the clipboard

---> the notification pulsing icon should be of the same type as the clipboard icon

[erikos]

When we drag&drop an object we do ​set the percentage to 100. This creates the notification ​right at the beginning when the data type has not been determined yet. The clipboard_icon itself we ​keep on updating when the state changes.

A fix would be to update the NotificationIcon as well when the state changes which passes my tests:

diff --git a/src/jarabe/frame/clipboardicon.py b/src/jarabe/frame/clipboardicon.py
index ebf3ad1..4baf844 100644
--- a/src/jarabe/frame/clipboardicon.py
+++ b/src/jarabe/frame/clipboardicon.py
@@ -121,6 +121,8 @@ class ClipboardIcon(RadioToolButton):
 
         if cb_object.get_icon():
             self._icon.props.icon_name = cb_object.get_icon()
+            if self._notif_icon:
+                self._notif_icon.props.icon_name = self._icon.props.icon_name
         else:
             self._icon.props.icon_name = 'application-octet-stream'

[erikos]

Pushed as: eb768ff8b39560a0a294c5733e9de2eaaf09dc1b

[dnarvaez]

Milestone 0.98 deleted