Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#3816 closed defect (fixed)

Remove simplejson dependency

Reported by: erikos Owned by: erikos
Priority: Unspecified by Maintainer Milestone:
Component: Sugar Version: 0.97.x
Severity: Major Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: Assigned

Description

We should only use one json implementatin, see #3142.

[erikos@t61 ~]$ grep -inr simplejson sugar-build/source/
sugar-build/source/sugar/src/jarabe/journal/expandedentry.py:27:import simplejson
sugar-build/source/sugar/src/jarabe/journal/expandedentry.py:297:      buddies = simplejson.loads(self._metadata['buddies']).values()
sugar-build/source/sugar/src/jarabe/journal/listmodel.py:19:import simplejson
sugar-build/source/sugar/src/jarabe/journal/listmodel.py:178:      buddies = simplejson.loads(metadata['buddies']).values()
sugar-build/source/sugar/src/jarabe/journal/listmodel.py:179:  except simplejson.decoder.JSONDecodeError, exception:
sugar-build/source/sugar/src/jarabe/journal/journalentrybundle.py:21:import simplejson
sugar-build/source/sugar/src/jarabe/journal/journalentrybundle.py:79:      return simplejson.loads(json_data)
sugar-build/source/sugar/src/jarabe/journal/model.py:28:import simplejson
sugar-build/source/sugar/src/jarabe/journal/model.py:467: metadata = simplejson.load(open(metadata_path))
sugar-build/source/sugar/src/jarabe/journal/model.py:727: metadata_json = simplejson.dumps(metadata_copy)
sugar-build/source/sugar/src/jarabe/journal/volumestoolbar.py:29:import simplejson
sugar-build/source/sugar/src/jarabe/journal/volumestoolbar.py:153:   os.write(fh, simplejson.dumps(metadata))
sugar-build/source/sugar/src/jarabe/model/invites.py:20:import simplejson
sugar-build/source/sugar/src/jarabe/model/invites.py:270: private_channel = simplejson.dumps([connection_name,
sugar-build/source/sugar/src/jarabe/model/bundleregistry.py:24:import simplejson
sugar-build/source/sugar/src/jarabe/model/bundleregistry.py:124:     favorites_data = simplejson.load(open(favorites_path))
sugar-build/source/sugar/src/jarabe/model/bundleregistry.py:352: simplejson.dump(favorites_data, open(path, 'w'), indent=1)
sugar-build/source/sugar-fructose/write/speechtoolbar.py:18:import simplejson
sugar-build/source/sugar-fructose/write/speechtoolbar.py:99:     speech_parameters = simplejson.load(f)
sugar-build/source/sugar-fructose/write/speechtoolbar.py:152:  simplejson.dump(speech_parameters, f)
sugar-build/source/sugar-fructose/terminal/terminal.py:21:import simplejson
sugar-build/source/sugar-fructose/terminal/terminal.py:398:        data = simplejson.loads(text)
sugar-build/source/sugar-fructose/terminal/terminal.py:455:#        text = simplejson.dumps(data)
sugar-build/source/sugar-fructose/read/speechtoolbar.py:18:import simplejson
sugar-build/source/sugar-fructose/read/speechtoolbar.py:97:    speech_parameters = simplejson.load(f)
sugar-build/source/sugar-fructose/read/speechtoolbar.py:126: simplejson.dump(speech_parameters, f)
sugar-build/source/sugar-fructose/turtleart/TurtleArt/tautils.py:38:     import simplejson as json
sugar-build/source/sugar-fructose/turtleart/TurtleArt/tautils.py:39:     from simplejson import load as jload
sugar-build/source/sugar-fructose/turtleart/TurtleArt/tautils.py:40:     from simplejson import dump as jdump 

Attachments (1)

0003-Move-from-simplejson-to-standard-library-json-SL-381.patch (7.5 KB) - added by manuq 8 years ago.
Patch for sugar component

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by manuq

Patch for sugar component

comment:1 Changed 8 years ago by manuq

Patch became old. Sent new one as merge request and to the ML:

https://github.com/sugarlabs/sugar/pull/23

comment:2 Changed 8 years ago by manuq

  • Resolution set to fixed
  • Status changed from new to closed

Merged in github master as c5d34fa9 .

comment:3 Changed 8 years ago by dnarvaez

  • Milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.