In "My Settings" -> "ModemConfiguration", convert the procedure to process the results of "connection.get_secrets('gsm', _secrets_cb, _secrets_err_cb)" from pseudo-asynchronous to asynchronous.

[ajay_garg]

In the method "get_modem_settings()", we call "connection.get_secrets('gsm', _secrets_cb, _secrets_err_cb)". This is an asynchronous call.

As of now, we busy wait, till the specified "result" callback is called (which in this case happens to be "def _secrets_cb(secrets)". After this is called, we return the modem-settings.

Instead of busy waiting, pass a callabck from the callee function. Thereafter, when "def _secrets_cb(secrets)" is hit, execute this callback function, passing the modem-settings.

[ajay_garg]

Patch (for sugar 0.98, mainline) at ::
​http://patchwork.sugarlabs.org/patch/1643/

[ajay_garg]

Version-2 Patch (for sugar 0.98, mainline) at ::
​http://patchwork.sugarlabs.org/patch/1645/

Changes of version-2 over version-1 ::::
=======================================

a)
Fixed a typo in the description.

Thanks James Cameron :)

b)
Removed extraneous comments.

Thanks James Cameron :)

[walter]

Not sure why this never landed, but a similar patch has been submitted here:

​https://github.com/sugarlabs/sugar/pull/53

[dnarvaez]

The pull request seems unrelated. Please submit a pull request with this patch.