Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#3656 closed defect (obsolete)

Browse: theme the autosuggestion toolbar correctly

Reported by: erikos Owned by: erikos
Priority: Normal Milestone:
Component: Browse Version: 0.96.x
Severity: Major Keywords: 12.1.0
Cc: Distribution/OS: Unspecified
Bug Status: New

Description

Regressions:

  • there is a gap between the entry and the suggestion window
  • the window is white (it was gray before)

Improvements:

  • add a border
  • separate the items by a line

Change History (3)

comment:1 Changed 8 years ago by erikos

This one is tricky. We do have global settings in the theme for the background and the view which do block theming that popup window.

In Browse I added a gtype_name in order to theme the window:

class SearchWindow(Gtk.Window):
    __gtype_name__ = 'BrowseSearchWindow'

    def __init__(self):
	Gtk.Window.__init__(self, type=Gtk.WindowType.POPUP)

The Window itself get themed by the .background clause in the theme so we can do

BrowseSearchWindow.background {
    background-color: @black;
}

to theme that.

The window is actually covered by the TextView which gets themed by the .view clause. Doing the following does should normally handle it.

BrowseSearchWindow * {
    background-color: @black;
    color: @white;
    border-style: solid;
    border-width: $(thickness)px;
    border-color: @button_grey;
}

comment:2 Changed 7 years ago by manuq

  • Resolution set to obsolete
  • Status changed from new to closed

Already fixed in #4049 .

comment:3 Changed 7 years ago by dnarvaez

  • Milestone 0.96 deleted

Milestone 0.96 deleted

Note: See TracTickets for help on using tickets.