#3654 closed defect (fixed)
Activity strings in global scope go untranslated
| Reported by: | dsd | Owned by: | erikos |
|---|---|---|---|
| Priority: | Urgent | Milestone: | |
| Component: | Sugar | Version: | 0.96.x |
| Severity: | Major | Keywords: | 12.1.0, olpc-test-passed |
| Cc: | Distribution/OS: | Unspecified | |
| Bug Status: | Assigned |
Description
As detailed in http://lists.sugarlabs.org/archive/sugar-devel/2012-May/037678.html activity code is being imported before gettext is configured. This results in some activities displaying untranslated strings, such as Physics, which loads strings in global scope.
0.96 regression.
Attachments (2)
Change History (11)
comment:1 Changed 11 years ago by erikos
- Milestone changed from Unspecified by Release Team to 0.96
comment:2 Changed 11 years ago by dsd
comment:3 Changed 11 years ago by erikos
- Bug Status changed from Unconfirmed to Assigned
- Priority changed from Unspecified by Maintainer to Urgent
- Severity changed from Unspecified to Major
Ok, adjusted the patch now as Daniel suggested and added a comment. I have tested on the XO and both Clock and Physics are translated fine now.
comment:4 Changed 11 years ago by erikos
We went back to removing the langpackdir feature. Adjusted the shell/toolkit/toolkit-gtk3 accordingly. Moved the initialisation of gettext into 'sugar-activity' so it happens early enough. Can be tested with Physics.
Is in: sugar-0.96.2, sugar-toolkit-0.96.3, sugar-toolkit-gtk3-0.96.3
comment:5 Changed 11 years ago by erikos
- Keywords olpc-test-pending added
- Resolution set to fixed
- Status changed from new to closed
comment:6 Changed 11 years ago by erikos
Actually, sugar-toolkit-gtk3-0.96.4 should be used.
comment:7 Changed 11 years ago by greenfeld
- Keywords olpc-test-passed added; olpc-test-pending removed
Translation of strings in Clock and Physics works again in 12.1.0 os13.
comment:8 Changed 10 years ago by dnarvaez
- Component changed from sugar-toolkit to Sugar
Looks good. When moving forward please add a comment in the sugar-activity addition explaining why gettext needs to be run so early, and similarly please explain in the shell patch why we load the value into the environment.