Opened 7 years ago

Closed 4 years ago

#3645 closed defect (fixed)

Port Terminal to GTK+3

Reported by: manuq Owned by: danielfrancis
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Terminal Version: Git as of bugdate
Severity: Unspecified Keywords: gtk3, patch
Cc: humitos Distribution/OS: Unspecified
Bug Status: New

Description (last modified by danielfrancis)

Agus and Daniel started the port in EduJAM sprint, please document in this ticket if you have any blockers.

Attachments (1)

0001-GTK3-Port.patch (9.2 KB) - added by danielfrancis 7 years ago.
Patch with the port to GTK3

Download all attachments as: .zip

Change History (11)

Changed 7 years ago by danielfrancis

Patch with the port to GTK3

comment:1 follow-up: Changed 7 years ago by danielfrancis

  • Description modified (diff)
  • Owner changed from RafaelOrtiz to danielfrancis
  • Status changed from new to accepted

Pending save data in journal.

comment:2 in reply to: ↑ 1 ; follow-up: Changed 7 years ago by manuq

Replying to danielfrancis:

Pending save data in journal.

Great. What is the exact blocker? Which function or method is available in GTK2 and not in GTK3? Is this already reported upstream?

comment:3 in reply to: ↑ 2 Changed 7 years ago by danielfrancis

Replying to manuq:

Replying to danielfrancis:

Pending save data in journal.

Great. What is the exact blocker? Which function or method is available in GTK2 and not in GTK3? Is this already reported upstream?

The method vte.Terminal.get_text was moved in GTK3, we need it to save the session store in Journal.

comment:5 Changed 7 years ago by humitos

Well, there is another issue pending to solve here: drag and drop.

The only case when it's useful is to drag and drop something from the clipboard to the Terminal screen. This action will paste all the content of that clipboard on the Terminal. godiard mentioned this on the sugar devel list and I think it's important.

Can you fill in a new ticket for this upstream?

comment:6 Changed 7 years ago by aguz

I reported the vte bug in gnome bugzilla:
https://bugzilla.gnome.org/show_bug.cgi?id=677000

comment:7 follow-up: Changed 7 years ago by danielfrancis

  • Bug Status changed from Unconfirmed to Resolved

Here is the new ticket with the Drag and Drop task.
http://bugs.sugarlabs.org/ticket/3655

comment:8 in reply to: ↑ 7 Changed 7 years ago by manuq

  • Bug Status changed from Resolved to New

Replying to danielfrancis:

Here is the new ticket with the Drag and Drop task.
http://bugs.sugarlabs.org/ticket/3655

Thanks Dani, we will mark this as resolved when the patch lands in the git repository.

comment:9 Changed 6 years ago by humitos

I found a new regression issue related with the port: #3717

comment:10 Changed 4 years ago by godiard

  • Resolution set to fixed
  • Status changed from accepted to closed

Already ported. Bugs should be opened as needed.

Note: See TracTickets for help on using tickets.