Opened 8 years ago

Last modified 7 years ago

#3633 new defect

Browse saves form values across forms with similar variable names

Reported by: greenfeld Owned by: erikos
Priority: Unspecified by Maintainer Milestone: Unspecified
Component: Browse Version: 0.96.x
Severity: Unspecified Keywords: 12.1.0, patch
Cc: dsd, manuq Distribution/OS: OLPC
Bug Status: Unconfirmed

Description

Browse saves form values across forms with similar variable names.

I do not know if this is an olpc-library bug with its default HTML page, or a Browse/Webkit bug.

Reproduction

  1. Start Browse on a XO with 12.1.0 os11.
  2. Search for something like "XO 1.5" using the "Find OLPC materials" section and " Search OLPC " search button.
  3. At the Google results page, press the Back button in Browse.
  4. The search query entered in step #2 has moved from the bottom OLPC-specific search text entry area to the top generic Google search text entry area.

Attachments (1)

0001-Proper-names-to-index-search-inputs-SL-3633.patch (1.8 KB) - added by humitos 7 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 7 years ago by humitos

  • Cc dsd manuq added
  • Keywords patch added

Here the problem is related to the index.html file because it has the same "name" value for both input fields.

comment:2 Changed 7 years ago by dsd

They are two different forms though, so if that is the reason, this patch is a workaround at best. Also, have you checked that google accepts different field names for the search query? Seems unlikely, but is possible.

If it works, and if we do apply this it needs to be accompanied with a webkit bug (including trivial test case).

Note: See TracTickets for help on using tickets.