Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#3622 closed defect (fixed)

Incorrect PDF filename is shown in the tab title

Reported by: humitos Owned by: manuq
Priority: Unspecified by Maintainer Milestone:
Component: Browse Version: Unspecified
Severity: Unspecified Keywords: 12.1.0, patch, olpc-test-passed
Cc: humitos, erikos, manuq Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description (last modified by humitos)

Steps to reproduce it:

  1. Open Browse
  2. Open a PDF file without title (for example:
  3. Save it in the Journal by clicking the button at the bottom
  4. Close Browse
  5. Go to the Journal
  6. Open the last Browse instance


The tab with the PDF file shows the filename (hashed) took from the datastore. In this case: db3371a3-dccb-488b-84c7-3d8962a6f2f3.pdf

Expected behavior:

I think it should show the original filename (mla.pdf).

Attachments (2)

pdf_title_fix.patch (805 bytes) - added by manuq 12 years ago.
0002-Display-the-filename-for-untitled-PDFs-stored-in-the.patch (1.4 KB) - added by manuq 12 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 12 years ago by humitos

  • Description modified (diff)

comment:2 Changed 12 years ago by manuq

  • Owner changed from erikos to manuq
  • Status changed from new to assigned

Changed 12 years ago by manuq

comment:3 Changed 12 years ago by manuq

The attached patch fixes the issue. However, I would like to improve it, removing the line with the comment "#ugly".

comment:4 Changed 12 years ago by manuq

Seems that the ugly line is needed.

comment:5 Changed 12 years ago by manuq

  • Keywords 12.1.0 patch added

comment:6 Changed 12 years ago by humitos

Good! This works!

I tested this on XO 1.75 os11 and git version of Browse.

comment:7 Changed 12 years ago by erikos

Works, thanks for the patch, please push.

comment:8 Changed 12 years ago by manuq

  • Keywords olpc-test-pending added
  • Resolution set to fixed
  • Status changed from assigned to closed

Pushed as 2009091c304fa892727d90c23e93257ffa150d6b

comment:9 Changed 12 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

The journal's filename for the PDF is used if present (as long as you are not hovering over the URL line to see the journal:// URI, which still shows the hash tag).

Tested in OLPC 12.1.0 os16/Browse-140.

comment:10 Changed 11 years ago by dnarvaez

  • Milestone 0.96 deleted

Milestone 0.96 deleted

Note: See TracTickets for help on using tickets.