Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#3620 closed defect (fixed)

Browse is displaying "Loading..." in the tab that triggers a download or a PDF load

Reported by: manuq Owned by: erikos
Priority: Unspecified by Maintainer Milestone:
Component: Browse Version: Unspecified
Severity: Unspecified Keywords: 12.1.0, patch, olpc-test-passed
Cc: humitos Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

TestCase:

Thay are changing now to "Loading...".

Attachments (2)

fix_loading.patch (2.8 KB) - added by manuq 8 years ago.
0001-Unset-loading.-message-when-the-loading-fails-SL-362.patch (3.7 KB) - added by manuq 8 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 8 years ago by manuq

  • Cc humitos added
  • Component changed from untriaged to Browse
  • Keywords 12.1.0 added
  • Milestone changed from Unspecified by Release Team to 0.96
  • Owner set to erikos

Changed 8 years ago by manuq

comment:2 Changed 8 years ago by manuq

When browse handles a pdf or a download, the loading status of the webview in the current tab changes to WEBKIT_LOAD_PROVISIONAL and then to WEBKIT_LOAD_FAILED. I will take a look at Epiphany code to see if this is expected, as WebKit documentation is not telling me.

fix_loading.patch is a fix for this bug, if the "failed" status is expected.

comment:3 Changed 8 years ago by manuq

Yes, what Ephy does is similar, it just unsets the "Loading..." title when failed. Sending the patch to the mailing list.

comment:4 Changed 8 years ago by manuq

  • Keywords patch added

comment:5 Changed 8 years ago by humitos

I think it works properly. I'm going to explain what happens here:

  1. Open Browse
  2. Go to this url ticket
  3. Click on the link file (in the description)
  4. The tab title changes to "Loading..."
  5. When the download is done, the tab title changes again to title of the webpage.

If this is the expected behavior, this patch works! :)

I tested this on XO 1.75 os11 and git version of Browse

comment:6 Changed 8 years ago by erikos

This does work as expected. Good work to look at the epiphany code for reference. Please push that one.

comment:7 Changed 8 years ago by manuq

  • Keywords olpc-test-pending added
  • Resolution set to fixed
  • Status changed from new to closed

Pushed as d6c56f8184de2b3980aca34fb644d2a8f0f4b64f

comment:8 Changed 8 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

This is fixed in 12.1.0 os16/Browse-140.

comment:9 Changed 7 years ago by dnarvaez

  • Milestone 0.96 deleted

Milestone 0.96 deleted

Note: See TracTickets for help on using tickets.