Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#3590 closed defect (fixed)

Sugar-artwork gtk3: Toggle button in the toolbar have wrong background when pressed.

Reported by: godiard Owned by: erikos
Priority: Normal Milestone:
Component: Sugar Version: Git as of bugdate
Severity: Minor Keywords: 12.1.0, patch
Cc: garnacho Distribution/OS: OLPC
Bug Status: Assigned

Description

Yo can see in the gtk3 Read activity (v99), the toggle button with the star, is used to create/remove bookmarks. When pressed, should have a gray rounded square in the background, but show a black square.

Change History (9)

comment:1 Changed 9 years ago by erikos

  • Owner changed from benzea to erikos
  • Status changed from new to assigned

comment:2 Changed 9 years ago by garnacho

FYI, I've just attached a patch in Ticket #3387 that also helps with this one, although this isn't exactly a dup either :)

comment:3 Changed 9 years ago by erikos

  • Keywords 12.1.0 patch added
  • Version changed from Unspecified to Git as of bugdate

The patch in #3387 http://bugs.sugarlabs.org/attachment/ticket/3387/0001-Fix-artifacts-in-share-button-SL-3387.patch does display the gray background with rounded corners. The only difference now left is to make it slightly smaller than the border of the palette. But I am a bit stuck on that one.

comment:4 Changed 9 years ago by godiard

Tested in Read activity. Please push.

comment:5 Changed 9 years ago by erikos

  • Bug Status changed from Unconfirmed to Assigned
  • Distribution/OS changed from Unspecified to OLPC
  • Priority changed from Unspecified by Maintainer to Normal
  • Severity changed from Unspecified to Minor

Thanks Gonzalo for testing! I pushed the patch now with a more detailed description as: http://git.sugarlabs.org/sugar-artwork/mainline/commit/54ef96860a93eb5c95ea019c12cd4dc388117398

I tried to use marging+padding to get the active highlight with a border as before but without success yet. So I would leave this one open. Severity for 0.96 I would say is minor now.

comment:6 Changed 9 years ago by manuq

Gary gave positive feedback in today's dev meeting. Any more comments? Is current patch ok to land?

comment:7 Changed 9 years ago by erikos

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed, as well verified by Manuel.

comment:8 Changed 8 years ago by dnarvaez

  • Component changed from sugar-artwork to Sugar

comment:9 Changed 8 years ago by dnarvaez

  • Milestone 0.96 deleted

Milestone 0.96 deleted

Note: See TracTickets for help on using tickets.