Opened 9 years ago

Last modified 9 years ago

#3581 accepted defect

Title is not updated properly

Reported by: humitos Owned by: humitos
Priority: Low Milestone: Unspecified
Component: Browse Version: 0.96.x
Severity: Unspecified Keywords: screenshot, patch
Cc: humitos, manuq, garycmartin Distribution/OS: Unspecified
Bug Status: Assigned

Description (last modified by humitos)

Steps to reproduce it:

  1. Open a new instance of Browse
  2. Go to http://google.com
  3. Take an screenshot (pressing Alt + 1)
  4. Go to the Journal
    • the name of the screenshot will be: "Screenshot of 'Browse Activity'
  5. Go back to Browse
  6. Go to http://wikipedia.com
  7. Take another screenshot
  8. Go to the Journal
    • the name of the screenshot will be: "Screenshot of 'Google'"

Expected behavior:

Use the title of the web page to name the Screenshot or "Browse Activity" if the page doesn't have a title.

Environment:

  • jhbuild - Debian Testing
  • git version of Browse

Attachments (3)

browse-title-screenshot.png (86.3 KB) - added by humitos 9 years ago.
Screenshot of _Browse Activity_.png (59.5 KB) - added by humitos 9 years ago.
os12 XO 1.75
0001-Show-the-correct-window-title-SL-3581.patch (895 bytes) - added by humitos 9 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 9 years ago by humitos

Even more, if you go back to the Browser after the step 8) , and go to http://sugarlabs.org and take another screenshot it will be named "Wikipedia".

Changed 9 years ago by humitos

comment:2 Changed 9 years ago by humitos

  • Cc manuq added

comment:3 Changed 9 years ago by humitos

  • Description modified (diff)
  • Keywords screenshot added
  • Owner changed from erikos to humitos
  • Status changed from new to accepted

comment:4 Changed 9 years ago by humitos

From here:

"Screen capture; saved to Journal as a PNG file named "Screenshot of N" where N is the activity or window name"

So,

  1. we should set the title for the current page to name the file: "Screenshot of '<web title>'"
  2. we should remove the title of the window to name it as: "Screenshot of N"

I vote for the first approach. What do you think?

comment:5 Changed 9 years ago by humitos

This screenshot is clear and I think that it shows why we should go for the "Screenshot of '<web title>'" option. The title of the window is used in the frame too, it would be good to put the correct title there.

Take a look at the following screenshot that shows the actual behavior.

Changed 9 years ago by humitos

os12 XO 1.75

comment:6 Changed 9 years ago by humitos

  • Keywords patch added

comment:7 follow-up: Changed 9 years ago by erikos

  • Bug Status changed from Unconfirmed to Assigned
  • Cc garycmartin added
  • Version changed from Unspecified to 0.96.x

So the "taking a screenshot of an activity"-behavior is the following:

It will be the name of the activity you are taking a screenshot from. Browse does adjust the name of the activity with the page you have been visiting last when it saves it's state to the Journal. (you can override that behavior when you set a title for the activity manually, in that case a flag is stored to prevent overwriting that user decision).

What happens in the case you are describing is the following: You load page 'x'. The title of the activity is not changed. You take a screenshot. It will be the activity title, not the page title. You switch to the Journal. The activity title is updated with the page title. If you go back to Browse (without loading a new page) and take a screenshot then it will have the activity title (now the current activity page) in the name.

So how to make this now more user friendly, or at least consistent:

  • trigger a save on every page load (would produce a lot of saves)
  • have a way of getting some extra information from Browse to the screenshot taking tool: to be able to do something like "Screenshot "Browse activity" page: wikipedia" or put the extra information into the metadata
  • use always the default title in Browse and do not update with the page title: if you consider multiple tabs etc this might not be appropriate in any case, we can consider putting that information into the metadata so it is available in the search in the Journal

comment:8 in reply to: ↑ 7 Changed 9 years ago by humitos

Replying to erikos:

  • trigger a save on every page load (would produce a lot of saves)

This is the only way that I found, I did it and I don't like where I put the set_text method. But as you said, a lot of saves will be done.

  • have a way of getting some extra information from Browse to the screenshot taking tool: to be able to do something like "Screenshot "Browse activity" page: wikipedia" or put the extra information into the metadata

I didn't find the way to do this. I think there is no way to inform the activity about that a screenshot is going to be taken. I mean, the activity is not informed about that.

  • use always the default title in Browse and do not update with the page title: if you consider multiple tabs etc this might not be appropriate in any case, we can consider putting that information into the metadata so it is available in the search in the Journal

With "default title in Browse" you mean use always "Screenshot "Browse activity"" ? In that case, we should never change the title of the window. Again, how do you think that we can include metadata in the screenshot entry (in the Journal) if the activity doesn't know anything about the screenshot?

comment:9 Changed 9 years ago by humitos

  • Summary changed from Title in not updated properly to Title is not updated properly

comment:10 Changed 9 years ago by humitos

  • Priority changed from Unspecified by Maintainer to Low
Note: See TracTickets for help on using tickets.