Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#3565 closed defect (fixed)

Theme scroll button in the tray

Reported by: erikos Owned by: manuq
Priority: High Milestone:
Component: Sugar Version: Git as of bugdate
Severity: Major Keywords: regression, r+, olpc-test-passed
Cc: erikos Distribution/OS: Unspecified
Bug Status: New

Description

see how it looks like at the moment: http://bugs.sugarlabs.org/attachment/ticket/3522/bookmarks_tray.png

and how it could look like (example from Record), note that Record has a different behavior as well as the icons are shown all the time but changes the state active/inactive:
http://bugs.sugarlabs.org/attachment/ticket/3522/tray_record.png

http://bugs.sugarlabs.org/attachment/ticket/3522/tray_record_can_scroll.png

Not a regression, but if there is an easy fix, let's do it.

Attachments (3)

3565-preliminar.patch (3.1 KB) - added by manuq 9 years ago.
Preliminar patch
0001-Tray-wrap-them-in-EventBoxes-in-order-to-make-them-t.patch (4.3 KB) - added by manuq 8 years ago.
Candidate patch for 1.
0001-Tray-Set-background-color-SL-3565.patch (921 bytes) - added by manuq 8 years ago.
Artwork patch for 2.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 9 years ago by erikos

  • Milestone changed from 0.96 to 0.98

Moving out that we fix the regressions first.

comment:2 Changed 9 years ago by manuq

  • Cc erikos added
  • Owner changed from erikos to manuq
  • Status changed from new to assigned

Changed 9 years ago by manuq

Preliminar patch

comment:3 Changed 9 years ago by manuq

Sugar trays are gtk boxes that pack buttons in both ends, and a gtk viewport in the middle. The viewport packs a gtk toolbar.

What we need here is 1. paint the background of those boxes, and 2. style the buttons.

For 2 we just need to add the gtype_name and the attached patch does so.

For 1 we have to convert the boxes to EventBoxes because otherwise the background is not themeable: https://bugzilla.gnome.org/show_bug.cgi?id=678790

I did so in the attached patch but now I have an issue in the _size_allocate_cb of _TrayViewport:

(tray.py:18161): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate widget with width -1280350453 and height 1

So I need fix that. Then, a patch for artwork is trivial.

Runing the testcase in toolkit-gtk3 tests/graphics/test.py is being useful to work on this.

comment:4 Changed 8 years ago by manuq

  • Priority changed from Unspecified by Maintainer to High

comment:5 Changed 8 years ago by manuq

  • Keywords regression added

Changed 8 years ago by manuq

Candidate patch for 1.

Changed 8 years ago by manuq

Artwork patch for 2.

comment:6 Changed 8 years ago by manuq

  • Keywords r? added

The two patches, one for artwork and one for toolkit, make the style correct again.

comment:7 Changed 8 years ago by manuq

  • Keywords r+ olpc-test-pending added; r? removed
  • Resolution set to fixed
  • Status changed from assigned to closed

Pushed toolkit d418d1cb artwork 8b24e667 .

comment:8 Changed 8 years ago by erikos

When testing #3565 I came across #4279. Your theme changes do works well, thanks for this.

comment:9 Changed 8 years ago by greenfeld

  • Keywords olpc-test-passed added; olpc-test-pending removed

The favorites bar in Browse now has sugar-like dark-background arrows in Sugar 0.98.3 (although the oblong oval highlight when touched/hovered looks a bit odd).

comment:10 Changed 8 years ago by dnarvaez

  • Component changed from sugar-artwork to Sugar

comment:11 Changed 8 years ago by dnarvaez

  • Milestone 0.98 deleted

Milestone 0.98 deleted

Note: See TracTickets for help on using tickets.